fix: fix possible fmt exceptions where we might have passed null string#5115
Open
lgritz wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Open
fix: fix possible fmt exceptions where we might have passed null string#5115lgritz wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
lgritz wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
I've heard occasional reports of uncaught exceptions in print
statements. I haven't caught it in the act yet, but one set of reports
involved the following output:
OpenImageIO/detail/fmt/format-inl.h:40: assertion failed: string pointer is null
So I'm proactively trying to find places that might be passing a null
as a string. I'm just guessing here, but these are plausible candidates.
Signed-off-by: Larry Gritz <lg@larrygritz.com>
jessey-git
requested changes
Mar 28, 2026
Signed-off-by: Larry Gritz <lg@larrygritz.com>
Contributor
|
Oh, hmm, I'll note here that based on the upstream code in libraw, it looks like |
Collaborator
Author
|
I think these are worth keeping to protect against future mistakes or changed behavior in libraw? I had no evidence that these were the fmt problems; I just was searching for ANY places where it could be null ptr. Maybe after merging #5118 it will force a few more exceptions (in main) and we'll find the real source quickly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've heard occasional reports of uncaught exceptions in print statements. I haven't caught it in the act yet, but one set of reports involved the following output:
So I'm proactively trying to find places that might be passing a null as a string. I'm just guessing here, but these are plausible candidates.