Skip to content

Comments

Refactor tests to run Playwright's server in Docker#485

Merged
IvanGoncharov merged 1 commit intomainfrom
pr_branch
Jan 29, 2026
Merged

Refactor tests to run Playwright's server in Docker#485
IvanGoncharov merged 1 commit intomainfrom
pr_branch

Conversation

@IvanGoncharov
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings January 29, 2026 19:09
@github-actions
Copy link

github-actions bot commented Jan 29, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/playwright 1.53.0 🟢 6.5
Details
CheckScoreReason
Maintained🟢 1030 commit(s) out of 30 and 6 issue activity out of 30 found in the last 90 days -- score normalized to 10
Code-Review🟢 9GitHub code reviews found for 29 commits out of the last 30 -- score normalized to 9
CII-Best-Practices⚠️ 0no badge detected
Vulnerabilities🟢 10no vulnerabilities detected
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 10security policy file detected
License🟢 10license file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1no published package detected
Token-Permissions⚠️ 0non read-only tokens detected in GitHub workflows
Binary-Artifacts🟢 6binaries present in source code
Dependency-Update-Tool🟢 10update tool detected
Fuzzing⚠️ 0project is not fuzzed
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Branch-Protection🟢 3branch protection is not maximal on development and all release branches

Scanned Files

  • package-lock.json
  • package.json

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the test infrastructure to run Playwright's server in Docker, changing from the @playwright/test package to the standalone playwright package and configuring tests to connect to a remote Playwright server running in a Docker container.

Changes:

  • Replaced @playwright/test dependency with playwright package across all test files
  • Simplified Docker setup to run only a Playwright server instead of full test environment
  • Modified test configuration to connect to the remote Playwright server via WebSocket

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
tests/webpack.spec.ts Changed import from '@playwright/test' to 'playwright/test'
tests/express.spec.ts Changed import from '@playwright/test' to 'playwright/test'
tests/demo.spec.ts Changed import from '@playwright/test' to 'playwright/test'
tests/PageObjectModel.ts Changed import from '@playwright/test' to 'playwright/test'
tests/Dockerfile Simplified to install only playwright globally and run server
playwright.config.ts Added WebSocket connection config and playwright-server web server
package.json Replaced '@playwright/test' with 'playwright' in devDependencies
package-lock.json Updated lock file to reflect dependency change
docker-compose.yml Removed test execution services, kept only playwright-server

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

projects: [
{
name: 'Demo',
testMatch: 'Demo.spec.ts',
Copy link

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testMatch value "Demo.spec.ts" uses an uppercase 'D' but the actual test file is named "demo.spec.ts" with a lowercase 'd'. This mismatch will cause the Demo tests to not be found and executed. The testMatch should be changed to "demo.spec.ts" to match the actual filename.

Suggested change
testMatch: 'Demo.spec.ts',
testMatch: 'demo.spec.ts',

Copilot uses AI. Check for mistakes.
@IvanGoncharov IvanGoncharov merged commit 656b8dd into main Jan 29, 2026
18 checks passed
@IvanGoncharov IvanGoncharov deleted the pr_branch branch January 29, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant