Refactor tests to run Playwright's server in Docker#485
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
47c330a to
de2249e
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors the test infrastructure to run Playwright's server in Docker, changing from the @playwright/test package to the standalone playwright package and configuring tests to connect to a remote Playwright server running in a Docker container.
Changes:
- Replaced
@playwright/testdependency withplaywrightpackage across all test files - Simplified Docker setup to run only a Playwright server instead of full test environment
- Modified test configuration to connect to the remote Playwright server via WebSocket
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/webpack.spec.ts | Changed import from '@playwright/test' to 'playwright/test' |
| tests/express.spec.ts | Changed import from '@playwright/test' to 'playwright/test' |
| tests/demo.spec.ts | Changed import from '@playwright/test' to 'playwright/test' |
| tests/PageObjectModel.ts | Changed import from '@playwright/test' to 'playwright/test' |
| tests/Dockerfile | Simplified to install only playwright globally and run server |
| playwright.config.ts | Added WebSocket connection config and playwright-server web server |
| package.json | Replaced '@playwright/test' with 'playwright' in devDependencies |
| package-lock.json | Updated lock file to reflect dependency change |
| docker-compose.yml | Removed test execution services, kept only playwright-server |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| projects: [ | ||
| { | ||
| name: 'Demo', | ||
| testMatch: 'Demo.spec.ts', |
There was a problem hiding this comment.
The testMatch value "Demo.spec.ts" uses an uppercase 'D' but the actual test file is named "demo.spec.ts" with a lowercase 'd'. This mismatch will cause the Demo tests to not be found and executed. The testMatch should be changed to "demo.spec.ts" to match the actual filename.
| testMatch: 'Demo.spec.ts', | |
| testMatch: 'demo.spec.ts', |
de2249e to
dfa8857
Compare
No description provided.