Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This PR refactors the GraphQL Voyager graph generation to use the dotviz library's JSON format instead of manually building DOT language strings. The main benefit is improved type safety and maintainability by leveraging dotviz's structured Graph, Node, and Edge types.
- Refactored
getDot()to return a structuredGraphobject instead of a DOT format string - Migrated from string concatenation to building typed nodes and edges arrays
- Updated graphviz-worker to handle the AggregateError constructor
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/graph/dot.ts | Complete refactoring from string-based DOT generation to structured Graph object using dotviz types, with extracted helper functions for field labels |
| src/graph/svg-renderer.ts | Added debugging code to render and log the raw DOT format output alongside SVG rendering |
| src/graph/graphviz-worker.ts | Updated AggregateError constructor call (though with an error in the implementation) |
| cspell.yml | Added 'tailport' to the dictionary for the new dotviz terminology |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b79887f to
36cc8f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.