Expose dotviz options up the call stack#480
Merged
IvanGoncharov merged 1 commit intomainfrom Dec 7, 2025
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This PR refactors the dotviz rendering API to expose render options up the call stack, making the API more flexible and explicit. Instead of hardcoding render options deep in the implementation, they can now be specified at the call site.
Key changes:
- Introduced a
RenderArgsinterface to encapsulate both input and rendering options - Renamed
renderString()torender()to reflect the broader parameter acceptance - Updated cache key generation to include render options alongside the input
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/graph/svg-renderer.ts |
Updated to call render() with explicit options object instead of renderString() |
src/graph/graphviz-worker.ts |
Introduced RenderArgs interface, refactored methods to accept render options, and updated cache key generation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.