Skip to content

Comments

Switch to using dotviz instead of custom build of graphviz#475

Merged
IvanGoncharov merged 1 commit intomainfrom
pr_branch2
Dec 6, 2025
Merged

Switch to using dotviz instead of custom build of graphviz#475
IvanGoncharov merged 1 commit intomainfrom
pr_branch2

Conversation

@IvanGoncharov
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 6, 2025 12:13
@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Dec 6, 2025
@github-actions
Copy link

github-actions bot commented Dec 6, 2025

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

License Issues

package-lock.json

PackageVersionLicenseIssue Type
dotviz0.0.6NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
npm/dotviz 0.0.6 UnknownUnknown

Scanned Files

  • package-lock.json

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request replaces a custom Docker-based graphviz build with the dotviz npm package, significantly simplifying the build process and dependency management.

Key Changes:

  • Removed custom C++/Emscripten worker build in favor of the dotviz package
  • Updated worker integration code to use dotviz's API
  • Removed Docker build infrastructure and related scripts

Reviewed changes

Copilot reviewed 10 out of 47 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/graph/graphviz-worker.ts Updated to integrate with dotviz package API instead of custom worker
package.json Added dotviz dependency and removed build:worker script
webpack.config.ts Removed worker-dist alias, reordered asset/source rule
worker/* Removed custom C++ worker implementation and type definitions
scripts/bundle_worker.ts Removed Docker-based worker build script
docker-compose.yml Removed build-worker service
tests/-snapshots/.svg Updated SVG output snapshots (minor rendering differences)
Configuration files Updated to remove worker-dist references

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@IvanGoncharov IvanGoncharov merged commit 7b64724 into main Dec 6, 2025
18 checks passed
@IvanGoncharov IvanGoncharov deleted the pr_branch2 branch December 6, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: polish 💅 PR doesn't change public API or any observed behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant