Switch to using dotviz instead of custom build of graphviz#475
Merged
IvanGoncharov merged 1 commit intomainfrom Dec 6, 2025
Merged
Switch to using dotviz instead of custom build of graphviz#475IvanGoncharov merged 1 commit intomainfrom
IvanGoncharov merged 1 commit intomainfrom
Conversation
Dependency ReviewThe following issues were found:
License Issuespackage-lock.json
OpenSSF Scorecard
Scanned Files
|
There was a problem hiding this comment.
Pull request overview
This pull request replaces a custom Docker-based graphviz build with the dotviz npm package, significantly simplifying the build process and dependency management.
Key Changes:
- Removed custom C++/Emscripten worker build in favor of the
dotvizpackage - Updated worker integration code to use dotviz's API
- Removed Docker build infrastructure and related scripts
Reviewed changes
Copilot reviewed 10 out of 47 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/graph/graphviz-worker.ts | Updated to integrate with dotviz package API instead of custom worker |
| package.json | Added dotviz dependency and removed build:worker script |
| webpack.config.ts | Removed worker-dist alias, reordered asset/source rule |
| worker/* | Removed custom C++ worker implementation and type definitions |
| scripts/bundle_worker.ts | Removed Docker-based worker build script |
| docker-compose.yml | Removed build-worker service |
| tests/-snapshots/.svg | Updated SVG output snapshots (minor rendering differences) |
| Configuration files | Updated to remove worker-dist references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1e3ef2c to
b0e2958
Compare
b0e2958 to
931c2a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.