Store model entity IDs and names in ReturnData
#3111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3111 +/- ##
==========================================
- Coverage 78.21% 77.55% -0.67%
==========================================
Files 315 315
Lines 20480 20487 +7
Branches 1484 1484
==========================================
- Hits 16019 15888 -131
- Misses 4453 4591 +138
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dweindl
force-pushed
the
gh-3107-ids-to-rdata
branch
from
4327f29 to
d2837c7
Compare
This makes `ReturnData` more usable without additionally passing around the corresponding `Model`, and avoids the previous hack for setting those IDs specifically for `RDataReporting::full`. Only `span`s are copied, so barely any additional memory is required.
dweindl
force-pushed
the
gh-3107-ids-to-rdata
branch
from
d2837c7 to
a939966
Compare
FFroehlich
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
ReturnDatamore usable without additionally passing around the correspondingModel, and avoids the previous hack for setting those IDs specifically forRDataReporting::full.Only
spans are copied, so barely any additional memory is required.Related to #3107.