Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3110 +/- ##
==========================================
- Coverage 78.29% 77.52% -0.77%
==========================================
Files 315 315
Lines 20524 20480 -44
Branches 1500 1485 -15
==========================================
- Hits 16069 15877 -192
- Misses 4446 4595 +149
+ Partials 9 8 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Refactor name and ID handling as preparation for AMICI-dev#3107. * Store IDs/names in const string_view array and only pass around spans to avoid always constructing new vectors * Store solver state IDs/names arrays instead of creating them dynamically, to be compatible with the previous point * Update tests accordingly * Add the respective typemaps * Regenerate test models
dweindl
force-pushed
the
stringview_ids
branch
from
66ea8b1 to
0d6f26a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor name and ID handling as preparation for #3107.