Skip to content

Update ValuesUtilities.GetValuesFor to support all primitives #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
John-Leitch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update ValuesUtilities.GetValuesFor to support all primitives #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions src/Xunit.Combinatorial/ValuesUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,23 +38,20 @@ internal static class ValuesUtilities
{
Requires.NotNull(dataType, nameof(dataType));

if (dataType == typeof(bool))
{
yield return true;
yield return false;
}
else if (dataType == typeof(int))
{
yield return 0;
yield return 1;
}
else if (dataType.GetTypeInfo().IsEnum)
if (dataType.GetTypeInfo().IsEnum)
{
foreach (string name in Enum.GetNames(dataType))
{
yield return Enum.Parse(dataType, name);
}
}
else if (dataType.IsPrimitive)
{
foreach (var i in new[] { 0, 1 })
{
yield return Convert.ChangeType(i, dataType);
}
}
else if (IsNullable(dataType, out Type? innerDataType))
{
yield return null;
Expand Down