Conversation
| - name: Docs | ||
| env: | ||
| DOCS_TOKEN: ${{ secrets.DOCS_TOKEN }} | ||
| TIBANNA_VERSION: 2.2.0 |
There was a problem hiding this comment.
The docs-deploy GA does not work anymore. I think that's because it can't determine the version, since it is now parsed from pyproject.toml. One solution would be to set the env variable here. Not elegant at all, but I am not sure how to get it otherwise.
I had the same issue with the Lambda function and solved it there via env variables.
|
|
||
| # AWSF image version - will default to the minor version of the deployed Tibanna | ||
| tibanna_version = semantic_version.Version(__version__) | ||
| __awsf_image_version__ = str(semantic_version.Version(major=tibanna_version.major, minor=tibanna_version.minor, patch=0)) |
There was a problem hiding this comment.
I would import __awsf_image_version__ into tibanna_ff as we do with __version__ to bring that change to CGAP.
willronchetti
left a comment
willronchetti
left a comment
There was a problem hiding this comment.
I would make a note about this in the deployment documentation - namely that updates to the awsf image must always update the minor version in light of this change.
| - name: Docs | ||
| env: | ||
| DOCS_TOKEN: ${{ secrets.DOCS_TOKEN }} | ||
| TIBANNA_VERSION: 2.2.0 |
There was a problem hiding this comment.
This version won't matter for the docs build though right?
There was a problem hiding this comment.
I think the version matters. It is also used in the conf.py in the docs folder.
2 participants
I think it would be helpful, if the release of patches was simpler.
I suggest that the AWSF image defaults to the minor version of the deployed Tibanna. E.g. if Tibanna version 2.1.1 is deployed, the default AWSF image is 2.1.0. The advantage would be that patch releases only require a redeploy of Tibanna but not a new docker image. If the docker image required changes, it should be a minor release anyway.