enable smoke test with CRD 3scale client #643
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pehala
suggested changes
May 24, 2023
Contributor
pehala
left a comment
pehala
left a comment
There was a problem hiding this comment.
These are significant changes to both test logic and test setup and they are completely missing any explanation of why they are needed.
testsuite/tests/apicast/policy/routing/test_routing_policy_headers.py
Outdated
Show resolved
Hide resolved
testsuite/tests/apicast/policy/routing/test_routing_policy_headers.py
Outdated
Show resolved
Hide resolved
testsuite/tests/apicast/policy/routing/test_routing_policy_multiple_conditions_or.py
Outdated
Show resolved
Hide resolved
mganisin
reviewed
May 24, 2023
mkudlej
force-pushed
the
capabilities_client
branch
from
4c20ac1 to
847fe4d
Compare
mkudlej
force-pushed
the
capabilities_client
branch
6 times, most recently
from
0605f8d to
6527d07
Compare
mkudlej
force-pushed
the
capabilities_client
branch
2 times, most recently
from
029505e to
b0d78c2
Compare
mkudlej
changed the title
jakurban
reviewed
Apr 2, 2024
mkudlej
force-pushed
the
capabilities_client
branch
from
b0d78c2 to
3ad3429
Compare
Member
|
@mkudlej please add note about capabilities tests to the documentation for the next generations :) |
Member
|
@mkudlej please unify setting of cluster project with testsuite logic. (1. level get project from dynaconf settings, 2.level NAMESPACE variable, fallback to current project from oc tool) |
dhlavac
reviewed
Apr 18, 2024
mkudlej
force-pushed
the
capabilities_client
branch
from
3ad3429 to
f360b4b
Compare
jakurban
reviewed
May 6, 2024
Comment on lines
+57
to
+58
| def api_client_type(pytestconfig): | ||
| """Do tests use REST API client(False) or CR Capabilities client(True)?""" |
Contributor
There was a problem hiding this comment.
I would rename this fixture to something like use_capabilities_client to match bool return value and for more clear usage later in the code.
mdujava
force-pushed
the
capabilities_client
branch
from
f360b4b to
46da2c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It introduces APIAP for all smoke tests with related changes.