fix: add missing parentheses to @torch.inference_mode decorator#991
Open
jnMetaCode wants to merge 2 commits into2noise:devfrom
Open
fix: add missing parentheses to @torch.inference_mode decorator#991jnMetaCode wants to merge 2 commits into2noise:devfrom
jnMetaCode wants to merge 2 commits into2noise:devfrom
Conversation
Signed-off-by: JiangNan <1394485448@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ChatTTS/model/tokenizer.py, thedecodemethod uses@torch.inference_modewithout parentheses, while theencodemethod (and every other usage across the codebase) correctly uses@torch.inference_mode().Without parentheses,
torch.inference_modeis applied as a raw class rather than as a decorator factory. This means thedecodemethod gets replaced by thetorch.inference_modecontext manager object itself, instead of being wrapped with inference mode enabled. As a result, callingdecodewon't actually perform any decoding — it silently returns the context manager.This patch adds the missing
()to match the rest of the codebase and restore correct behavior.