Remove test.expect_* calls and expected files#980
Merged
Conversation
Renamed `test.compiled_package()` to `test.compile_package()` to highlight that it runs Wasm->MASM compilation. Before that, the `test.expect_masm` calls compiled Wasm->MASM and cache a package and `test.compiled_package` returned the cached package.
… not included anywhere
bitwalker
approved these changes
Feb 23, 2026
Collaborator
bitwalker
left a comment
bitwalker
left a comment
There was a problem hiding this comment.
LGTM! It'll be nice to avoid all the churn in PRs for sure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #973
This PR removes calls to
test.expect_*in the integration files and the corresponding expected files.I recommend reviewing this PR on a per-commit basis.
Why
We planned to stop abusing the
expecttests and use the proper--emitinfra to get the introspection into the pipeline in #816.How I'm doing introspection now
I set
export MIDENC_EMIT=ir=ir_dumpbefore running the tests and I have<leader>min my neovim config to fuzzy search the emitted files to open the one I'm interested in in the editor.