Conversation
985a9b8 to
b85107e
Compare
This was referenced Feb 16, 2026
6d56821 to
b051225
Compare
Contributor
|
I bet the reason is CompilerTest::rust_fn_body that calls rustc directly. So you can either find trim-path equivalent in rustc options or switch to CompilerTest::rust_fn_body_with_* that uses cargo.
|
Contributor
|
The globals are placed after the 'rodata'. |
Contributor
Author
|
Thanks for the hints! It was due to the path difference in With rustc's |
greenhat
approved these changes
Feb 19, 2026
Contributor
greenhat
left a comment
There was a problem hiding this comment.
Looking good! Nice job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the
overflowingpart of #912.Even though it doesn't fully resolve #912, I'd like to put this PR up for review to get feedback on the approach of using a generic function instead of macros.
Generated files in
expected/Should they be generated and committed for these tests? For now I did that to be consistent with existing tests.
For passing tests I did not review these files, assuming matching
rust_outandvm_outis sufficient. Though the generated files can be very helpful to get an idea of generated code and inspect it in case of failures. So another option could be writing these files only if specifically requested or when an error occurs.