Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ maturin build --release

## Benchmark

Outperforms `requests`, `httpx`, `aiohttp`, and `curl_cffi`, and you can see the [benchmark](https://github.com/0x676e67/wreq-python/tree/main/bench) for details benchmark data is for reference only and actual performance may vary based on your environment and use case.
Outperforms `requests`, `httpx`, `aiohttp`, and `curl_cffi`, and you can see the [benchmark](https://github.com/0x676e67/wreq-python/tree/main/bench) for details. The benchmark suite is driven by `pytest-benchmark`, and results are still for reference only because network and system conditions affect outcomes.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The README states that the benchmark suite is driven by pytest-benchmark, but the PR title and the implementation in bench/benchmark.py indicate a migration to pyperf. This description should be updated to reflect the correct tool to avoid confusion for users.


## Services

Expand Down
9 changes: 4 additions & 5 deletions bench/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ Sync clients
- requests
- niquests
- pycurl
- [python-tls-client](https://github.com/FlorianREGAZ/Python-Tls-Client.git)
- httpx
- wreq
- ry
Expand All @@ -64,12 +63,12 @@ All the clients run with session/client enabled.
## Run benchmark

```bash
# Install dependencies
pip install -r requirements.txt
# Install project + benchmark dependencies
pip install -e .[bench]

# Start server
python server.py

# Start benchmark
# Run benchmark suite
python benchmark.py
```
```
Loading
Loading