Skip to content

Commit 79a5783

Browse files
dcpleungnashif
authored andcommitted
coredump: fix ruff warnings on top level scripts
This fixes ruff warnings on top level coredump scripts. This is done via "ruff check --fix" without manual editing. Note SIM115 is not fixed yet as it requires more intrusive changes to handle opened file with context manager. Signed-off-by: Daniel Leung <[email protected]>
1 parent 37b8402 commit 79a5783

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

.ruff-excludes.toml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,6 @@
128128
"I001", # https://docs.astral.sh/ruff/rules/unsorted-imports
129129
"UP015", # https://docs.astral.sh/ruff/rules/redundant-open-modes
130130
]
131-
"./scripts/coredump/coredump_gdbserver.py" = [
132-
"I001", # https://docs.astral.sh/ruff/rules/unsorted-imports
133-
]
134131
"./scripts/coredump/coredump_parser/elf_parser.py" = [
135132
"E501", # https://docs.astral.sh/ruff/rules/line-too-long
136133
"I001", # https://docs.astral.sh/ruff/rules/unsorted-imports
@@ -146,9 +143,7 @@
146143
"UP032", # https://docs.astral.sh/ruff/rules/f-string
147144
]
148145
"./scripts/coredump/coredump_serial_log_parser.py" = [
149-
"I001", # https://docs.astral.sh/ruff/rules/unsorted-imports
150146
"SIM115", # https://docs.astral.sh/ruff/rules/open-file-with-context-handler
151-
"UP015", # https://docs.astral.sh/ruff/rules/redundant-open-modes
152147
]
153148
"./scripts/coredump/gdbstubs/arch/arm64.py" = [
154149
"I001", # https://docs.astral.sh/ruff/rules/unsorted-imports

scripts/coredump/coredump_gdbserver.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,9 @@
1010
import socket
1111
import sys
1212

13-
from coredump_parser.log_parser import CoredumpLogFile
14-
from coredump_parser.elf_parser import CoredumpElfFile
15-
1613
import gdbstubs
14+
from coredump_parser.elf_parser import CoredumpElfFile
15+
from coredump_parser.log_parser import CoredumpLogFile
1716

1817
LOGGING_FORMAT = "[%(levelname)s][%(name)s] %(message)s"
1918

scripts/coredump/coredump_serial_log_parser.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import binascii
99
import sys
1010

11-
1211
COREDUMP_PREFIX_STR = "#CD:"
1312

1413
COREDUMP_BEGIN_STR = COREDUMP_PREFIX_STR + "BEGIN#"
@@ -28,7 +27,7 @@ def parse_args():
2827
def main():
2928
args = parse_args()
3029

31-
infile = open(args.infile, "r")
30+
infile = open(args.infile)
3231
if not infile:
3332
print(f"ERROR: Cannot open input file: {args.infile}, exiting...")
3433
sys.exit(1)

0 commit comments

Comments
 (0)