Skip to content

Commit 4cb678b

Browse files
committed
Merge pull request #5 from yupmin/fix-for-umd
Fix for umd
2 parents 179b362 + 2e3173b commit 4cb678b

5 files changed

Lines changed: 88 additions & 19 deletions

File tree

dist/js-package-sample.js

Lines changed: 29 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
/**
22
* Copyright (c) 2015
33
* js-package-sample - Javascript Package Sample
4-
* Built on 2015-12-16
4+
* Built on 2015-12-17
55
*
6-
* @version 0.0.4
6+
* @version 0.0.5
77
* @link https://github.com/yupmin/js-package-sample.git
88
* @license MIT
99
*/
@@ -22,7 +22,8 @@
2222
}(this, function (jQuery) {
2323
'use strict';
2424

25-
var userAgent;
25+
var userAgent,
26+
repeaterId;
2627

2728
return {
2829
getUserAgent: function() {
@@ -31,6 +32,30 @@
3132

3233
setUserAgent: function(ua) {
3334
userAgent = ua;
34-
}
35+
},
36+
37+
timerGetUserAgent: function(cb) {
38+
setTimeout(function(self) {
39+
try {
40+
cb(null, self.getUserAgent());
41+
} catch (err) {
42+
cb(err);
43+
}
44+
}, 1000, this);
45+
},
46+
47+
getRepeaterId: function() {
48+
return repeaterId;
49+
},
50+
51+
repeaterGetUserAgent: function(cb) {
52+
repeaterId = setInterval(function(self) {
53+
try {
54+
cb(null, self.getUserAgent());
55+
} catch (err) {
56+
cb(err);
57+
}
58+
}, 1000, this);
59+
},
3560
};
3661
}));

dist/js-package-sample.min.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
/**
22
* Copyright (c) 2015
33
* js-package-sample - Javascript Package Sample
4-
* Built on 2015-12-16
4+
* Built on 2015-12-17
55
*
6-
* @version 0.0.4
6+
* @version 0.0.5
77
* @link https://github.com/yupmin/js-package-sample.git
88
* @license MIT
99
*/
1010

11-
!function(a,b){"function"==typeof define&&define.amd?define(["jquery"],b):"object"==typeof exports?module.exports=b(require("jquery")):a.JsPackageSample=b(a.jQuery)}(this,function(a){"use strict";var b;return{getUserAgent:function(){return b},setUserAgent:function(a){b=a}}});
11+
!function(a,b){"function"==typeof define&&define.amd?define(["jquery"],b):"object"==typeof exports?module.exports=b(require("jquery")):a.JsPackageSample=b(a.jQuery)}(this,function(a){"use strict";var b,c;return{getUserAgent:function(){return b},setUserAgent:function(a){b=a},timerGetUserAgent:function(a){setTimeout(function(b){try{a(null,b.getUserAgent())}catch(c){a(c)}},1e3,this)},getRepeaterId:function(){return c},repeaterGetUserAgent:function(a){c=setInterval(function(b){try{a(null,b.getUserAgent())}catch(c){a(c)}},1e3,this)}}});

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "js-package-sample",
3-
"version": "0.0.4",
3+
"version": "0.0.5",
44
"description": "Javascript Package Sample",
55
"main": "dist/js-package-sample.js",
66
"scripts": {

src/index.js

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
}(this, function (jQuery) {
1313
'use strict';
1414

15-
var userAgent;
15+
var userAgent,
16+
repeaterId;
1617

1718
return {
1819
getUserAgent: function() {
@@ -21,6 +22,30 @@
2122

2223
setUserAgent: function(ua) {
2324
userAgent = ua;
24-
}
25+
},
26+
27+
timerGetUserAgent: function(cb) {
28+
setTimeout(function(self) {
29+
try {
30+
cb(null, self.getUserAgent());
31+
} catch (err) {
32+
cb(err);
33+
}
34+
}, 1000, this);
35+
},
36+
37+
getRepeaterId: function() {
38+
return repeaterId;
39+
},
40+
41+
repeaterGetUserAgent: function(cb) {
42+
repeaterId = setInterval(function(self) {
43+
try {
44+
cb(null, self.getUserAgent());
45+
} catch (err) {
46+
cb(err);
47+
}
48+
}, 1000, this);
49+
},
2550
};
2651
}));

test/index.js

Lines changed: 28 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
1+
var expect;
2+
13
if (typeof module !== 'undefined' && module.exports) { // Node.js
2-
var expect = require('chai').expect;
3-
var sinon = require('sinon');
4-
var jsdom = require('jsdom');
5-
// var window = jsdom.jsdom(
6-
// '<html><head></head><body>hello world</body></html>'
7-
// ).defaultView;
8-
// var navigator = window.navigator;
4+
var sinon = require('sinon'),
5+
jsdom = require('jsdom');
6+
7+
expect = require('chai').expect;
8+
9+
GLOBAL.window = jsdom.jsdom(
10+
'<html><head></head><body>hello world</body></html>'
11+
).defaultView;
912

1013
var JsPackageSample = require('../src/index');
1114
} else {
12-
var expect = chai.expect;
15+
expect = chai.expect;
1316
}
1417

15-
1618
describe('JS Package Sample', function() {
1719
it('setUserAgent function', function() {
1820
expect(JsPackageSample.setUserAgent('test')).to.equal(undefined);
@@ -22,4 +24,21 @@ describe('JS Package Sample', function() {
2224
JsPackageSample.setUserAgent('test');
2325
expect(JsPackageSample.getUserAgent()).to.equal('test');
2426
});
27+
28+
it('timerGetUserAgent function', function(done) {
29+
JsPackageSample.setUserAgent('test');
30+
JsPackageSample.timerGetUserAgent(function(err, res) {
31+
expect(res).to.equal('test');
32+
done();
33+
});
34+
});
35+
36+
it('repeaterGetUserAgent function', function(done) {
37+
JsPackageSample.setUserAgent('test');
38+
JsPackageSample.repeaterGetUserAgent(function(err, res) {
39+
expect(res).to.equal('test');
40+
clearInterval(JsPackageSample.getRepeaterId());
41+
done();
42+
});
43+
});
2544
});

0 commit comments

Comments
 (0)