Skip to content

Commit 343f9f4

Browse files
committed
Fix properties
1 parent eda5c26 commit 343f9f4

12 files changed

+17
-37
lines changed

src/Modern/Middleware/AbstractDataResponseMiddleware.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@
1313

1414
abstract class AbstractDataResponseMiddleware implements MiddlewareInterface
1515
{
16-
protected readonly FormatterInterface $formatter;
16+
public function __construct(
17+
private readonly FormatterInterface $formatter,
18+
) {}
1719

1820
final public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
1921
{

src/Modern/Middleware/DataResponseMiddleware.php

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,4 @@
44

55
namespace Yiisoft\DataResponse\Modern\Middleware;
66

7-
use Yiisoft\DataResponse\Modern\Formatter\FormatterInterface;
8-
9-
final class DataResponseMiddleware extends AbstractDataResponseMiddleware
10-
{
11-
public function __construct(FormatterInterface $formatter)
12-
{
13-
$this->formatter = $formatter;
14-
}
15-
}
7+
final class DataResponseMiddleware extends AbstractDataResponseMiddleware {}

src/Modern/Middleware/HtmlDataResponseMiddleware.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ final class HtmlDataResponseMiddleware extends AbstractDataResponseMiddleware
1010
{
1111
public function __construct(HtmlFormatter $formatter = new HtmlFormatter())
1212
{
13-
$this->formatter = $formatter;
13+
parent::__construct($formatter);
1414
}
1515
}

src/Modern/Middleware/JsonDataResponseMiddleware.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ final class JsonDataResponseMiddleware extends AbstractDataResponseMiddleware
1010
{
1111
public function __construct(JsonFormatter $formatter = new JsonFormatter())
1212
{
13-
$this->formatter = $formatter;
13+
parent::__construct($formatter);
1414
}
1515
}

src/Modern/Middleware/PlainTextDataResponseMiddleware.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ final class PlainTextDataResponseMiddleware extends AbstractDataResponseMiddlewa
1010
{
1111
public function __construct(PlainTextFormatter $formatter = new PlainTextFormatter())
1212
{
13-
$this->formatter = $formatter;
13+
parent::__construct($formatter);
1414
}
1515
}

src/Modern/Middleware/XmlDataResponseMiddleware.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ final class XmlDataResponseMiddleware extends AbstractDataResponseMiddleware
1010
{
1111
public function __construct(XmlFormatter $formatter = new XmlFormatter())
1212
{
13-
$this->formatter = $formatter;
13+
parent::__construct($formatter);
1414
}
1515
}

src/Modern/ResponseFactory/AbstractFormattedResponseFactory.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,10 @@
1212

1313
abstract class AbstractFormattedResponseFactory implements FormattedResponseFactoryInterface
1414
{
15-
protected ResponseFactoryInterface $responseFactory;
16-
protected FormatterInterface $formatter;
15+
public function __construct(
16+
private readonly ResponseFactoryInterface $responseFactory,
17+
private readonly FormatterInterface $formatter,
18+
) {}
1719

1820
final public function createResponse(
1921
mixed $data = null,

src/Modern/ResponseFactory/FormattedResponseFactory.php

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,4 @@
44

55
namespace Yiisoft\DataResponse\Modern\ResponseFactory;
66

7-
use Psr\Http\Message\ResponseFactoryInterface;
8-
use Yiisoft\DataResponse\Modern\Formatter\FormatterInterface;
9-
10-
final class FormattedResponseFactory extends AbstractFormattedResponseFactory
11-
{
12-
public function __construct(
13-
ResponseFactoryInterface $responseFactory,
14-
FormatterInterface $formatter,
15-
) {
16-
$this->responseFactory = $responseFactory;
17-
$this->formatter = $formatter;
18-
}
19-
}
7+
final class FormattedResponseFactory extends AbstractFormattedResponseFactory {}

src/Modern/ResponseFactory/HtmlResponseFactory.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ public function __construct(
1313
ResponseFactoryInterface $responseFactory,
1414
HtmlFormatter $formatter,
1515
) {
16-
$this->responseFactory = $responseFactory;
17-
$this->formatter = $formatter;
16+
parent::__construct($responseFactory, $formatter);
1817
}
1918
}

src/Modern/ResponseFactory/JsonResponseFactory.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ public function __construct(
1313
ResponseFactoryInterface $responseFactory,
1414
JsonFormatter $formatter,
1515
) {
16-
$this->responseFactory = $responseFactory;
17-
$this->formatter = $formatter;
16+
parent::__construct($responseFactory, $formatter);
1817
}
1918
}

0 commit comments

Comments
 (0)