Skip to content

Commit d41347a

Browse files
committed
xapi/qcow_tool_wrapper: Add note on using header information from VHD files
Signed-off-by: Andrii Sultanov <andriy.sultanov@vates.tech>
1 parent e86dfb0 commit d41347a

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

ocaml/xapi/qcow_tool_wrapper.ml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,11 @@ let send ?relative_to (progress_cb : int -> unit) (unix_fd : Unix.file_descr)
5050
to avoid reading all of the raw disk *)
5151
let input_fd = Result.map read_header qcow_path |> Result.to_option in
5252

53+
(* TODO: If VHD headers are to be consulted as well, qcow2-to-stdout
54+
needs to properly account for cluster_bits. Currently QCOW2 export
55+
from VHD-backed VDIs will just revert to raw, without any
56+
allocation accounting. *)
57+
5358
(* Parse the header of the VDI we are diffing against as well *)
5459
let relative_to_qcow_path =
5560
match relative_to with

0 commit comments

Comments
 (0)