Skip to content

Commit bcf47a8

Browse files
committed
xapi/qcow_tool_wrapper: Add note on using header information from VHD files
Signed-off-by: Andrii Sultanov <[email protected]>
1 parent 069b82c commit bcf47a8

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

ocaml/xapi/qcow_tool_wrapper.ml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,11 @@ let send ?relative_to (progress_cb : int -> unit) (unix_fd : Unix.file_descr)
5454
to avoid reading all of the raw disk *)
5555
let input_fd = Result.map read_header qcow_path |> Result.to_option in
5656

57+
(* TODO: If VHD headers are to be consulted as well, qcow2-to-stdout
58+
needs to properly account for cluster_bits. Currently QCOW2 export
59+
from VHD-backed VDIs will just revert to raw, without any
60+
allocation accounting. *)
61+
5762
(* Parse the header of the VDI we are diffing against as well *)
5863
let relative_to_qcow_path =
5964
match relative_to with

0 commit comments

Comments
 (0)