Fixes for scan-build and g++ warnings.

Author: dgarske

examples/nvram/extend.c

@@ -187,6 +187,10 @@ int TPM2_NVRAM_Extend_Example(void* userCtx, int argc, char *argv[])
     XMEMSET(policyOr, 0, sizeof(policyOr));
     rc = wolfTPM2_PolicyHash(hashAlg, policyOr, &nvSize,
         TPM_CC_PolicyOR, policyDigest, policyDigestSz);
+    if (rc != TPM_RC_SUCCESS) {
+        printf("wolfTPM2_PolicyHash failed!\n");
+        goto exit;
+    }
     printf("PolicyOR A/B/C: %d\n", nvSize);
     TPM2_PrintBin(policyOr, nvSize);
 
@@ -247,6 +251,10 @@ int TPM2_NVRAM_Extend_Example(void* userCtx, int argc, char *argv[])
             policyOr, nvSize
         );
     }
+    if (rc != 0) {
+        printf("NV Create failed!\n");
+        goto exit;
+    }
 
     /* Close session and unload endorsement */
     wolfTPM2_UnsetAuth(&dev, 0);

examples/tls/tls_client.c

@@ -439,7 +439,7 @@ int TPM2_TLS_ClientArgs(void* userCtx, int argc, char *argv[])
     #else
         void* pkey = NULL;
     #endif
-        rc = wolfTPM2_ExportPublicKeyBuffer(&dev, pkey,
+        rc = wolfTPM2_ExportPublicKeyBuffer(&dev, (WOLFTPM2_KEY*)pkey,
             ENCODING_TYPE_ASN1, der, &derSz);
         if (rc < 0) {
             printf("Failed to export TPM public key!\n");

examples/tls/tls_server.c

@@ -432,7 +432,7 @@ int TPM2_TLS_ServerArgs(void* userCtx, int argc, char *argv[])
     #else
         void* pkey = NULL;
     #endif
-        rc = wolfTPM2_ExportPublicKeyBuffer(&dev, pkey,
+        rc = wolfTPM2_ExportPublicKeyBuffer(&dev, (WOLFTPM2_KEY*)pkey,
             ENCODING_TYPE_ASN1, der, &derSz);
         if (rc < 0) {
             printf("Failed to export TPM public key!\n");

src/tpm2_wrap.c

@@ -7891,7 +7891,6 @@ static int tpm2_ifx_firmware_data(WOLFTPM2_DEV* dev,
         rc = cb(&cmd[2], IFX_FW_MAX_CHUNK_SZ, offset, cb_ctx);
         if (rc > 0 && rc <= IFX_FW_MAX_CHUNK_SZ) {
             chunk_sz = rc;
-            rc = 0;
         }
         else if (rc == 0) {
         #ifdef DEBUG_WOLFTPM