Fix suggestions to add descriptions when description is empty. (#6487)

* Fix suggestions to add descriptions when description is empty.

* Break out into function.

Author: dbrant

app/src/main/java/org/wikipedia/suggestededits/provider/EditingSuggestionsProvider.kt

@@ -66,9 +66,7 @@ object EditingSuggestionsProvider {
                 var tries = 0
                 while (tries++ <= retryLimit && title.isEmpty()) {
                     // Fetch a batch of random articles, and get the ones that have no description.
-                    val resultsWithNoDescription = ServiceFactory.get(wiki).getRandomPages().query?.pages?.filter {
-                        it.description.isNullOrEmpty()
-                    }.orEmpty()
+                    val resultsWithNoDescription = fetchArticlesWithNullDescription(wiki)
 
                     articlesWithMissingDescriptionCacheLang = wiki.languageCode
 
@@ -120,9 +118,7 @@ object EditingSuggestionsProvider {
                 var tries = 0
                 while (tries++ <= retryLimit && titles == null) {
                     // Fetch a batch of random articles from the target language wiki, and get ones that have no description.
-                    val resultsWithNoDescription = ServiceFactory.get(targetWiki).getRandomPages().query?.pages?.filter {
-                        it.description.isNullOrEmpty()
-                    }.orEmpty()
+                    val resultsWithNoDescription = fetchArticlesWithNullDescription(targetWiki)
 
                     articlesWithTranslatableDescriptionCacheFromLang = sourceWiki.languageCode
                     articlesWithTranslatableDescriptionCacheToLang = targetLang
@@ -172,6 +168,15 @@ object EditingSuggestionsProvider {
         return pair
     }
 
+    private suspend fun fetchArticlesWithNullDescription(targetWiki: WikiSite): List<MwQueryPage> {
+        return ServiceFactory.get(targetWiki).getRandomPages().query?.pages?.filter {
+            // Important: we only want pages where the description is specifically null,
+            // instead of an empty string. An empty string implies the description is set
+            // to "none", which means the editors don't want a description added.
+            it.description == null
+        }.orEmpty()
+    }
+
     suspend fun getNextImageWithMissingCaption(lang: String, retryLimit: Long = MAX_RETRY_LIMIT): String {
         var title = ""
         withContext(Dispatchers.IO) {