Skip to content

Commit cf4d15b

Browse files
committed
Remove support for Ruby 3.1 and the aligned JRuby 9.4.
- rubycritic.gemspec: update minimum Ruby version to 3.2 - .rubocop.yml: update target Ruby version to 3.2 - CI: drop Ruby 3.1 and jruby 9.4 (Ruby 3.1) - bump mdl dependency to 0.15.0, which requires ruby 3.2 at minimum - bump minitest dependency to 6.0, which requires ruby 3.2 at minimum - minitest 6 unbundles minitest-mock, so include that and call it
1 parent 3f27dcd commit cf4d15b

File tree

5 files changed

+8
-17
lines changed

5 files changed

+8
-17
lines changed

.github/workflows/main.yml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,16 +28,13 @@ jobs:
2828
fail-fast: false
2929
matrix:
3030
ruby-version:
31-
- '3.1'
3231
- '3.2'
3332
- '3.3'
3433
- '3.4'
3534
experimental: [false]
3635
include:
3736
- ruby-version: 'ruby-head'
3837
experimental: true
39-
- ruby-version: 'jruby-9.4'
40-
experimental: true
4138
- ruby-version: 'jruby-10.0'
4239
experimental: true
4340
steps:
@@ -61,16 +58,13 @@ jobs:
6158
fail-fast: false
6259
matrix:
6360
ruby-version:
64-
- '3.1'
6561
- '3.2'
6662
- '3.3'
6763
- '3.4'
6864
experimental: [false]
6965
include:
7066
- ruby-version: 'ruby-head'
7167
experimental: true
72-
- ruby-version: 'jruby-9.4'
73-
experimental: true
7468
- ruby-version: 'jruby-10.0'
7569
experimental: true
7670
steps:
@@ -94,16 +88,13 @@ jobs:
9488
fail-fast: false
9589
matrix:
9690
ruby-version:
97-
- '3.1'
9891
- '3.2'
9992
- '3.3'
10093
- '3.4'
10194
experimental: [false]
10295
include:
10396
- ruby-version: 'ruby-head'
10497
experimental: true
105-
- ruby-version: 'jruby-9.4'
106-
experimental: true
10798
- ruby-version: 'jruby-10.0'
10899
experimental: true
109100
steps:
@@ -127,16 +118,13 @@ jobs:
127118
fail-fast: false
128119
matrix:
129120
ruby-version:
130-
- '3.1'
131121
- '3.2'
132122
- '3.3'
133123
- '3.4'
134124
experimental: [false]
135125
include:
136126
- ruby-version: 'ruby-head'
137127
experimental: true
138-
- ruby-version: 'jruby-9.4'
139-
experimental: true
140128
- ruby-version: 'jruby-10.0'
141129
experimental: true
142130
steps:

.rubocop.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ AllCops:
1111
- 'tmp/**/*'
1212
- 'vendor/**/*'
1313
- 'gemfiles/*'
14-
TargetRubyVersion: 3.1
14+
TargetRubyVersion: 3.2
1515

1616
Metrics/BlockLength:
1717
Enabled: false

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
* [CHORE] ...
66
* [FEATURE] ...
77

8+
* [CHANGE] Drop support for Ruby 3.1.x and JRuby 9.4 (by [@faisal][])
89
* [CHANGE] Add CI support for JRuby 10.0 (by [@faisal][])
910
* [CHANGE] Bump cucumber dependency (by [@faisal][])
1011
* [BUGFIX] Fixed regression in compatibility with Flog 4.9.0 (by [@faisal][])

rubycritic.gemspec

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Gem::Specification.new do |spec|
1515
spec.summary = 'RubyCritic is a Ruby code quality reporter'
1616
spec.homepage = 'https://github.com/whitesmith/rubycritic'
1717
spec.license = 'MIT'
18-
spec.required_ruby_version = '>= 3.1.0'
18+
spec.required_ruby_version = '>= 3.2.0'
1919

2020
spec.files = [
2121
'CHANGELOG.md',
@@ -56,9 +56,10 @@ Gem::Specification.new do |spec|
5656
spec.add_development_dependency 'diff-lcs', '~> 1.3'
5757
spec.add_development_dependency 'fakefs', '~> 3.0.0'
5858
spec.add_development_dependency 'irb'
59-
spec.add_development_dependency 'mdl', '~> 0.13.0', '>= 0.12.0'
60-
spec.add_development_dependency 'minitest', '~> 5.26.0', '>= 5.3.0'
61-
spec.add_development_dependency 'minitest-around', '~> 0.5.0', '>= 0.4.0'
59+
spec.add_development_dependency 'mdl', '~> 0.15.0', '>= 0.12.0'
60+
spec.add_development_dependency 'minitest', '~> 6.0.0'
61+
spec.add_development_dependency 'minitest-around', '~> 0.6.0'
62+
spec.add_development_dependency 'minitest-mock'
6263
spec.add_development_dependency 'mocha', '~> 3.0.0'
6364
spec.add_development_dependency 'ostruct'
6465
spec.add_development_dependency 'rake', '~> 13.3.0', '>= 11.0.0'

test/lib/rubycritic/commands/compare_test.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# frozen_string_literal: true
22

33
require 'test_helper'
4+
require 'minitest/mock'
45
require 'rubycritic/commands/compare'
56
require 'rubycritic/cli/options'
67
require 'rubycritic/configuration'

0 commit comments

Comments
 (0)