feat: improve tree shaking on defineStore (#2740)

serkodev · posva · web-flow · commit 3069105f1585 · 2024-08-15T19:38:42.000+02:00
add `#__NO_SIDE_EFFECTS__` notation to `defineStore`


---------

Co-authored-by: Eduardo San Martin Morote &lt;posva@users.noreply.github.com&gt;
diff --git a/packages/pinia/src/store.ts b/packages/pinia/src/store.ts
@@ -870,6 +870,8 @@ export function defineStore<Id extends string, SS>(
   _ExtractGettersFromSetupStore<SS>,
   _ExtractActionsFromSetupStore<SS>
 >
+// improves tree shaking
+/*#__NO_SIDE_EFFECTS__*/
 export function defineStore(
   // TODO: add proper types from above
   idOrOptions: any,

Original file line number	Diff line number	Diff line change
`@@ -870,6 +870,8 @@ export function defineStore<Id extends string, SS>(`
`870`	`870`	`_ExtractGettersFromSetupStore<SS>,`
`871`	`871`	`_ExtractActionsFromSetupStore<SS>`
`872`	`872`	`>`
	`873`	`+// improves tree shaking`
	`874`	`+/#__NO_SIDE_EFFECTS__/`
`873`	`875`	`export function defineStore(`
`874`	`876`	`// TODO: add proper types from above`
`875`	`877`	`idOrOptions: any,`