fix: required parameter should not be empty

Author: fundon

src/node.rs

@@ -210,6 +210,11 @@ impl<T: fmt::Debug> Node<T> {
                             });
                         }
                     } else {
+                        // if it's normal, parameter is required
+                        if k == &Kind::Normal && bytes[0] == b'/' {
+                            return None;
+                        }
+
                         // static
                         if let Some(id) = self.nodes0.as_ref().and_then(|nodes| {
                             nodes.iter().find_map(|node| match &node.key {

src/parser.rs

@@ -1,6 +1,10 @@
 use alloc::{string::ToString, vec::Vec};
 use core::{iter::Peekable, str::CharIndices};
 
+/// Types of path segments.
+///
+/// Represents the matching pattern for parameters in URL paths.
+/// Different kinds determine how parameters match URL path segments.
 #[derive(Clone, Copy, Debug, Eq, Ord, PartialEq, PartialOrd)]
 pub enum Kind {
     /// `:` 58

tests/issues.rs

@@ -0,0 +1,43 @@
+use path_tree::PathTree;
+
+#[test]
+fn test_44() {
+    let mut tree = PathTree::new();
+    let _ = tree.insert("/test/:me", 0);
+    let _ = tree.insert("/test/:me?", 1);
+    let _ = tree.insert("/test/:me/now", 2);
+    let _ = tree.insert("/test/:me?/now", 3);
+
+    let (value, path) = tree.find("/test/").unwrap();
+    assert_eq!(value, &1);
+    assert_eq!(path.params(), &[("me", "")]);
+
+    let (value, path) = tree.find("/test/now").unwrap();
+    assert_eq!(value, &0);
+    assert_eq!(path.params(), &[("me", "now")]);
+
+    // not found
+    let result = tree.find("/test//");
+    assert!(result.is_none());
+
+    let (value, path) = tree.find("/test//now").unwrap();
+    assert_eq!(value, &3);
+    assert_eq!(path.params(), &[("me", "")]);
+
+    let (value, path) = tree.find(r"/test/\/now").unwrap();
+    assert_eq!(value, &2);
+    assert_eq!(path.params(), &[("me", r"\")]);
+
+    // trim `/`
+    let trimed = "/test//now"
+        .split('/')
+        .filter(|s| !s.is_empty())
+        .collect::<Vec<_>>();
+    let mut path = trimed.join("/");
+    // add lead with `/`
+    path.insert(0, '/');
+    assert_eq!(path, "/test/now");
+    let (value, path) = tree.find(&path).unwrap();
+    assert_eq!(value, &0);
+    assert_eq!(path.params(), &[("me", "now")]);
+}