add IsShutdown field

Signed-off-by: Tim Vaillancourt <[email protected]>

Author: timvaillancourt

go/vt/proto/topodata/topodata.pb.go

@@ -191,15 +191,17 @@ func ReadTopologyInstanceBufferable(tabletAlias string, latency *stopwatch.Named
 		goto Cleanup
 	}
 
-	fs, err = fullStatus(tablet)
-	if err != nil {
-		goto Cleanup
-	}
-	if config.GetStalledDiskPrimaryRecovery() && fs.DiskStalled {
-		stalledDisk = true
-		goto Cleanup
+	if !tablet.IsShutdown {
+		fs, err = fullStatus(tablet)
+		if err != nil {
+			goto Cleanup
+		}
+		if config.GetStalledDiskPrimaryRecovery() && fs.DiskStalled {
+			stalledDisk = true
+			goto Cleanup
+		}
+		partialSuccess = true // We at least managed to read something from the server.
 	}
-	partialSuccess = true // We at least managed to read something from the server.
 
 	instance.Hostname = tablet.MysqlHostname
 	instance.Port = int(tablet.MysqlPort)

go/vt/proto/topodata/topodata_vtproto.pb.go

@@ -161,6 +161,8 @@ func NewClient() *Client {
 	}
 }
 
+// validateTablet confirms the tablet record contains the necessary fields
+// for talking gRPC.
 func validateTablet(tablet *topodatapb.Tablet) error {
 	if tablet.Hostname == "" {
 		return vterrors.New(vtrpcpb.Code_FAILED_PRECONDITION, "invalid tablet hostname")

go/vt/vtorc/inst/instance_dao.go

@@ -289,6 +289,7 @@ func BuildTabletFromInput(alias *topodatapb.TabletAlias, port, grpcPort int32, d
 		DbNameOverride:       initDbNameOverride,
 		Tags:                 mergeTags(buildTags, initTags),
 		DefaultConnCollation: uint32(charset),
+		IsShutdown:           false,
 	}, nil
 }
 
@@ -508,6 +509,7 @@ func (tm *TabletManager) Close() {
 		tablet.Hostname = ""
 		tablet.MysqlHostname = ""
 		tablet.PortMap = nil
+		tablet.IsShutdown = true
 		return nil
 	}
 

go/vt/vttablet/grpctmclient/client.go

@@ -166,6 +166,10 @@ message Tablet {
   // map<string, string> health_map = 11;
   // string db_server_version = 15;
   reserved 3, 11, 15;
+
+  // IsShutdown is set to true when the tablet cleanly completes a shutdown.
+  // This is set to false on tablet startup.
+  bool is_shutdown = 17;
 }
 
 // A Shard contains data about a subset of the data whithin a keyspace.