Git Colors hard to differentiate

[notpeter]

Hi @vitallium

Thanks for a great them. Small feedback

1. Highlighted line Color (line 1347) vs Git Diff lines are really similar.
   Tinted looks like a git remove line. Tritanopia looks like git add line.

Modus Operandi Tinted	Modus Operandi Tritanopia

2. In the Vivendi themes, the Git remove/add (line 1349 and above) colors are really subtle. At a glance, I don't know which of the 1349 is removed and which is added. (I mean I know the removed comes first, but still...)

Modus Vivendi Deuteranopia.	Modus Vivendi
Modus Vivendi Tinted	Modus Vivendi Tritanopia

Anyways, thanks for making (and maintaining) great themes!

[vitallium]

Hi, thanks for reporting this issue. I believe the problem is that Zed uses custom opacity for diff colors:
https://github.com/vitallium/zed/blob/6db974dd324e1b7f41f09a29c04e1234cc99723c/crates/editor/src/element.rs#L6942
This breaks the original purpose of these colors and makes them hard to differentiate.
For example, if I set the opacity to 1.0 on the linked line, the result looks like this:

With default opacity	With 1.0

This isn't ideal, of course, but it’s close to the original colors. Anyway, I’ll look into the best way to resolve the issue. Thanks!

[notpeter]

TIL!

[vitallium]

@notpeter hi! Could you please check if the git colors are still hard to differentiate? Thanks!

[notpeter]

Much better! Except Modus Operandi Tinted is still really close:

Modus Operandi Tinted

(thanks for taking the time to try and improve this)

[vitallium]

Opened a feature request for making diff hunks configurable zed-industries/zed#51667