File tree Expand file tree Collapse file tree 4 files changed +14
-32
lines changed
virtusize-core/src/main/java/com/virtusize/android/data/remote
main/java/com/virtusize/android/data/parsers
test/java/com/virtusize/android/parsers Expand file tree Collapse file tree 4 files changed +14
-32
lines changed Original file line number Diff line number Diff line change @@ -22,6 +22,7 @@ data class I18nLocalization(
2222 val sizeComparisonMultiSizeText : String ,
2323 val willFitResultText : String ,
2424 val willNotFitResultText : String ,
25+ val willNotFitResultDefaultText : String ,
2526 val bodyDataEmptyText : String ,
2627) {
2728 enum class TrimType {
Original file line number Diff line number Diff line change @@ -103,7 +103,7 @@ data class Product(
103103 return i18nLocalization.oneSizeWillFitResultText
104104 }
105105 // If willFit is false or no recommended size, show "Your size not found"
106- return i18nLocalization.willNotFitResultText
106+ return i18nLocalization.willNotFitResultDefaultText
107107 }
108108
109109 // No body data provided, check for product comparison
@@ -136,7 +136,7 @@ data class Product(
136136 )
137137 }
138138 // If willFit is false or no recommended size, show "Your size not found"
139- return i18nLocalization.willNotFitResultText
139+ return i18nLocalization.willNotFitResultDefaultText
140140 }
141141
142142 // No body data provided, check for product comparison
Original file line number Diff line number Diff line change @@ -115,7 +115,15 @@ internal class I18nLocalizationJsonParser(
115115 ),
116116 )?.trim().orEmpty()
117117
118- val willNotFitResultText = configuredContext.getString(
118+ val willNotFitResultText =
119+ inpageJSONObject?.optString(
120+ FIELD_WILL_NOT_FIT_RESULT ,
121+ configuredContext.getString(
122+ com.virtusize.android.core.R .string.inpage_will_not_fit_result_text,
123+ ),
124+ )?.trim().orEmpty()
125+
126+ val willNotFitResultDefaultText = configuredContext.getString(
119127 com.virtusize.android.core.R .string.inpage_will_not_fit_result_text,
120128 )
121129
@@ -142,6 +150,7 @@ internal class I18nLocalizationJsonParser(
142150 sizeComparisonMultiSizeText = sizeComparisonMultiSizeText,
143151 willFitResultText = willFitResultText,
144152 willNotFitResultText = willNotFitResultText,
153+ willNotFitResultDefaultText = willNotFitResultDefaultText,
145154 bodyDataEmptyText = bodyDataEmptyText,
146155 )
147156 }
Original file line number Diff line number Diff line change @@ -36,35 +36,6 @@ class I18nLocalizationJsonParserTest {
3636 assertThat(actualI18nLocalization).isEqualTo(expectedI18nLocalization)
3737 }
3838
39- @Test
40- fun parseI18N_emptyJsonData_shouldReturnExpectedObject () {
41- val actualI18nLocalization =
42- I18nLocalizationJsonParser (context, VirtusizeLanguage .EN ).parse(
43- TestFixtures .EMPTY_JSON_DATA ,
44- )
45-
46- val expectedI18nLocalization =
47- I18nLocalization (
48- VirtusizeLanguage .EN ,
49- " " ,
50- " " ,
51- " " ,
52- " " ,
53- " " ,
54- " " ,
55- " " ,
56- " " ,
57- " " ,
58- " " ,
59- " " ,
60- " " ,
61- " " ,
62- " " ,
63- )
64-
65- assertThat(actualI18nLocalization).isEqualTo(expectedI18nLocalization)
66- }
67-
6839 @Test
6940 fun parseI18NJP_japaneseLocalization_shouldReturnExpectedObject () {
7041 val actualI18nLocalization =
@@ -126,6 +97,7 @@ class I18nLocalizationJsonParserTest {
12697 localizedContext.getString(com.virtusize.android.core.R .string.inpage_multi_size_comparison_text),
12798 localizedContext.getString(com.virtusize.android.core.R .string.inpage_will_fit_result_text),
12899 localizedContext.getString(com.virtusize.android.core.R .string.inpage_will_not_fit_result_text),
100+ localizedContext.getString(com.virtusize.android.core.R .string.inpage_will_not_fit_result_text),
129101 localizedContext.getString(com.virtusize.android.core.R .string.inpage_body_data_empty_text),
130102 )
131103 }
You can’t perform that action at this time.
0 commit comments