Address Comments

Author: PineappleIOnic

src/Client.php

@@ -32,6 +32,7 @@ class Client
     private string $userAgent = '';
     private int $maxRetries = 0;
     private int $retryDelay = 1000; // milliseconds
+    private array $retryStatusCodes = [500, 503];
 
     /**
      * @param string $key
@@ -131,6 +132,18 @@ public function setRetryDelay(int $retryDelay): self
         return $this;
     }
 
+    /**
+     * Set the retry status codes.
+     *
+     * @param array<int> $retryStatusCodes
+     * @return self
+     */
+    public function setRetryStatusCodes(array $retryStatusCodes): self
+    {
+        $this->retryStatusCodes = $retryStatusCodes;
+        return $this;
+    }
+
     /**
      * Flatten request body array to PHP multiple format
      *
@@ -161,14 +174,14 @@ private static function flatten(array $data, string $prefix = ''): array
      * @return mixed
      * @throws \Exception
      */
-    private function retry(callable $callback): mixed
+    private function withRetries(callable $callback): mixed
     {
         $attempts = 1;
 
         while (true) {
             $res = $callback();
 
-            if ($res->getStatusCode() !== 500 && $res->getStatusCode() !== 503 || $attempts >= $this->maxRetries) {
+            if (!in_array($res->getStatusCode(), $this->retryStatusCodes) || $attempts >= $this->maxRetries) {
                 return $res;
             }
 
@@ -265,7 +278,7 @@ public function fetch(
         };
 
         if ($this->maxRetries > 0) {
-            $response = $this->retry($sendRequest);
+            $response = $this->withRetries($sendRequest);
         } else {
             $response = $sendRequest();
         }
@@ -342,4 +355,14 @@ public function getRetryDelay(): int
     {
         return $this->retryDelay;
     }
+
+    /**
+     * Get the retry status codes.
+     *
+     * @return array<int>
+     */
+    public function getRetryStatusCodes(): array
+    {
+        return $this->retryStatusCodes;
+    }
 }

tests/ClientTest.php

@@ -400,4 +400,22 @@ public function testRetryWithDelay(): void
         $this->assertEquals(200, $res->getStatusCode());
         unlink(__DIR__ . '/state.json');
     }
+
+    /**
+     * Test custom retry status codes
+     * @return void
+     */
+    public function testCustomRetryStatusCodes(): void
+    {
+        $client = new Client();
+        $client->setMaxRetries(3);
+        $client->setRetryDelay(3000);
+        $client->setRetryStatusCodes([401]);
+        $now = microtime(true);
+
+        $res = $client->fetch('localhost:8000/mock-retry-401');
+        $this->assertEquals(200, $res->getStatusCode());
+        $this->assertGreaterThan($now + 3.0, microtime(true));
+        unlink(__DIR__ . '/state.json');
+    }
 }

tests/router.php

@@ -67,6 +67,20 @@ function setState(array $newState): void
         throw new \Exception('Mock retry error');
     }
 
+    $body = json_encode([
+        'success' => true,
+        'attempts' => $state['attempts']
+    ]);
+} elseif ($curPageName == 'mock-retry-401') {
+    $state = getState();
+    $state['attempts'] = isset($state['attempts']) ? $state['attempts'] + 1 : 1;
+    setState($state);
+
+    if ($state['attempts'] <= 2) {
+        http_response_code(401);
+        throw new \Exception('Mock retry error');
+    }
+
     $body = json_encode([
         'success' => true,
         'attempts' => $state['attempts']