Probably minor issue: repeated elseif with same condition

[chsquare]

Hi Bene and Olaf,

I just noticed that cfg.method if-block within uf_glmfit function has two times 'matlab' and two times 'pinv' with slightly different code.

unfold/src/uf_toolbox/uf_glmfit.m

Line 125 in caa07fd

if strcmp(cfg.method,'matlab') % save time

unfold/src/uf_toolbox/uf_glmfit.m

Line 201 in caa07fd

elseif strcmp(cfg.method,'matlab') % save time

unfold/src/uf_toolbox/uf_glmfit.m

Line 133 in caa07fd

elseif strcmp(cfg.method,'pinv')

unfold/src/uf_toolbox/uf_glmfit.m

Line 210 in caa07fd

elseif strcmp(cfg.method,'pinv')

The output is probably (more or less) the same in both cases, but perhaps still something you want to fix.

Best,
Christoph

[behinger]

ha! good catch. I had used those for testing speed of several implementations. Probably I got confused and just let them stand here.

We can simply remove the later one, there is no improvement to be expected exactly as you said.