Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
===========================================
- Coverage 100.00% 91.79% -8.21%
===========================================
Files 1 5 +4
Lines 2 329 +327
===========================================
+ Hits 2 302 +300
- Misses 0 27 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
behinger
left a comment
There was a problem hiding this comment.
Some further comments:
- Any reason to have the ride methods in a folder ride?
- Any reason that the ride methods have a
ride_in the filenames? - The docs currently dont show any plots
- you seem to have still quite some code doubling in
ride_classic_algorithmandride_unfold_algorithm. I mostly checked the "prepare_data" phase, which reads near 1:1. I generally would prefer to have one "master"-loop?+´ - I think similarities between both approaches would appear starkly, once the code is refactored into smaller functions. Right now it is a very large near-monolithic function
I didnt look much more into the functions, because if you decide to put both methods together, I wouldnt need to review two separate files :)
| r_range = [0, 0.8], | ||
| c_range = [-0.4, 0.4], | ||
| c_estimation_range = [-0.1, 0.9], | ||
| formulas = [@formula(0 ~ 1), @formula(0 ~ 1), @formula(0 ~ 1 + reaction_time)] # formulas used for S, R, and C component |
There was a problem hiding this comment.
would it make sense to do:
formulas = ['S'=>@formula(0~1),'C'=>@formula(0~1),'R'=>@formula(0~1)], e.g. as a list of pairs? that would generalize to more events more readily and doesnt have the issue of order. You the only have to splice in the firbasis in the fit command down below
Updated the return values of the function to include the final model.
Now returns the final model of the Unfold algorithm, also fixes tests
This fixes the dsp sfreq bug and gets rid of quite some code doubling between the methods. Sorry for the gigantic commit....
Fix dsp bug/ code doubling/ docstrings
Related issues
Closes #36 #37
Checklist