Improving changes on feature detection safety

Author: nathanfallet

Sources/CodeScanner/ScannerViewController.swift

@@ -509,29 +509,27 @@ extension CodeScannerView.ScannerViewController: UIImagePickerControllerDelegate
             return
         }
 
-        var qrCodeLink = ""
-
         let features = detector.features(in: ciImage)
 
-        if features.isEmpty {
+        guard !features.isEmpty else {
             didFail(reason: .badOutput)
-        } else {
-            for feature in features.compactMap({ $0 as? CIQRCodeFeature }) {
-                guard let qrCodeLink = feature.messageString, !qrCodeLink.isEmpty else {
-                    didFail(reason: .badOutput)
-                    continue
-                }
+            return
+        } 
+        for feature in features.compactMap({ $0 as? CIQRCodeFeature }) {
+            guard let qrCodeLink = feature.messageString, !qrCodeLink.isEmpty else {
+                didFail(reason: .badOutput)
+                continue
+            }
 
-                let corners = [
-                    feature.bottomLeft,
-                    feature.bottomRight,
-                    feature.topRight,
-                    feature.topLeft
-                ]
+            let corners = [
+                feature.bottomLeft,
+                feature.bottomRight,
+                feature.topRight,
+                feature.topLeft
+            ]
 
-                let result = ScanResult(string: qrCodeLink, type: .qr, image: qrcodeImg, corners: corners)
-                found(result)
-            }
+            let result = ScanResult(string: qrCodeLink, type: .qr, image: qrcodeImg, corners: corners)
+            found(result)
         }
     }