Skip to content

Commit 1637b4f

Browse files
committed
Append content to DOM instead of setting innerHTML
Ensure that all bound events and data will remain attached to the element instead of "flattening" it to just HTML string.
1 parent ab358dc commit 1637b4f

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

js/transitions.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@
3939

4040
var displayBar = function (bar, container) {
4141
if (container) {
42-
container.innerHTML = bar.innerHTML;
42+
container.innerHTML = '';
43+
container.appendChild(bar);
4344
} else {
4445
// per Ratchet's CSS, bar elements must be the first thing in <body>
4546
// here we assume `.content` is an immediate child of <body>
@@ -115,7 +116,8 @@
115116
transitionContent(newContentDiv, existingContentDiv,
116117
transition, complete);
117118
} else {
118-
document.body.innerHTML = contents.innerHTML;
119+
document.body.innerHTML = '';
120+
document.body.appendChild(contents);
119121
complete && complete();
120122
}
121123
};

0 commit comments

Comments
 (0)