-
-
Notifications
You must be signed in to change notification settings - Fork 325
Fix native buy flow #23654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Fix native buy flow #23654
Conversation
d998479 to
1220294
Compare
|
✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found. |
jbazant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this? I am pretty much convinced that this PR solves the problems with instability in buy and exchange flow.
1220294 to
b6254c2
Compare
|
✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found. |
9b49f8e to
b0f8536
Compare
b0f8536 to
0980f00
Compare
Hmmm, I was not aware and I noticed your comment way to late :(
What do you say? |
fixes buyFlow testthat was done by this PR so I just make the test more robust.testWithRepeatwhich I used to test stability of my fix. You can replace originalit('<tests name>withtestWithRepeat(<number of repeats>, <test name>. Commit, push to CI, see results, revert commit. ATM I was not able to think of more cleaner solution. Unfortunately, Detox does not provide any support for this whatsoever🔍🖥️ Suite web test results: View in Currents
🔍🖥️ Suite desktop test results: View in Currents
🔍🖥️ Suite native android test results: View in Currents