Skip to content

Conversation

@Vere-Grey
Copy link
Contributor

@Vere-Grey Vere-Grey commented Dec 5, 2025

  • fixes buyFlow test that was done by this PR so I just make the test more robust.
  • new test wrapper testWithRepeat which I used to test stability of my fix. You can replace original it('<tests name> with testWithRepeat(<number of repeats>, <test name>. Commit, push to CI, see results, revert commit. ATM I was not able to think of more cleaner solution. Unfortunately, Detox does not provide any support for this whatsoever
  • new method waitToHaveRegex - waits for visibility and then with retry mechanism test either text, label or value based on you parameters.

🔍🖥️ Suite web test results: View in Currents

🔍🖥️ Suite desktop test results: View in Currents

🔍🖥️ Suite native android test results: View in Currents

@Vere-Grey Vere-Grey self-assigned this Dec 5, 2025
@Vere-Grey Vere-Grey requested a review from a team as a code owner December 5, 2025 13:26
@Vere-Grey Vere-Grey force-pushed the fix-native-buy-flow branch from d998479 to 1220294 Compare December 5, 2025 15:31
@trezor-bot
Copy link
Contributor

trezor-bot bot commented Dec 5, 2025

✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

Copy link
Contributor

@jbazant jbazant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this? I am pretty much convinced that this PR solves the problems with instability in buy and exchange flow.

@Vere-Grey Vere-Grey force-pushed the fix-native-buy-flow branch from 1220294 to b6254c2 Compare December 6, 2025 09:36
@trezor-bot
Copy link
Contributor

trezor-bot bot commented Dec 6, 2025

✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found.
⏭️ Skipping tests for this run.
💡 If you are unsure about your latest changes, please rerun the workflow manually. (Use the Re-run all jobs option)

@Vere-Grey Vere-Grey force-pushed the fix-native-buy-flow branch 2 times, most recently from 9b49f8e to b0f8536 Compare December 6, 2025 11:07
@Vere-Grey Vere-Grey force-pushed the fix-native-buy-flow branch from b0f8536 to 0980f00 Compare December 6, 2025 11:10
@Vere-Grey
Copy link
Contributor Author

Vere-Grey commented Dec 6, 2025

Do we really need this? I am pretty much convinced that this PR solves the problems with instability in buy and exchange flow.

@vytick , @jbazant

Hmmm, I was not aware and I noticed your comment way to late :(
So. I am not adding any fixed waits or timeout that will make the test longer. Just more robust so here are two options:

  • A, ditch the test improvements and just keep two new support methods
  • B, keep it all

What do you say?

@Vere-Grey Vere-Grey requested a review from vytick December 6, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants