fix(e2e-native): stabilize tradingBuyFlow test

Author: Vere-Grey

suite-native/app/e2e/pageObjects/trading/TradingFormActions.ts

@@ -1,7 +1,7 @@
 import { expect as detoxExpect } from 'detox';
 
 import { TradingActions } from './TradingActions';
-import { wait, waitForVisible } from '../../support/utils';
+import { wait, waitForVisible, waitToHaveRegex } from '../../support/utils';
 
 export abstract class TradingFormActions extends TradingActions {
     abstract waitForQuotesToLoad(): Promise<void>;
@@ -22,6 +22,10 @@ export abstract class TradingFormActions extends TradingActions {
         return this.getElementById('fiat-amount-input');
     }
 
+    getReceiveCryptoAmountElement() {
+        return this.getElementById('crypto-amount-input');
+    }
+
     getSendCryptoAmountElement() {
         return this.getElementById('send-amount-input');
     }
@@ -39,6 +43,7 @@ export abstract class TradingFormActions extends TradingActions {
         await this.expectSheetHeaderTitle('Currency');
         await this.getSearchFiatElement().replaceText(fiatCurrency.slice(0, -1));
         await wait(this.BOTTOM_SHEET_ANIMATION_DURATION);
+        await waitForVisible(by.text(fiatCurrency));
         await element(by.text(fiatCurrency)).tap();
 
         await waitFor(this.getElementById('fiat-button/ticker'))
@@ -53,6 +58,7 @@ export abstract class TradingFormActions extends TradingActions {
 
         await this.expectSheetHeaderTitle('Country of residence');
         await this.getSearchCountryElement().replaceText(countrySearch);
+        await waitForVisible(by.text(country));
         await element(by.text(country)).tap();
 
         await waitFor(this.getElementById('country/value'))
@@ -92,7 +98,9 @@ export abstract class TradingFormActions extends TradingActions {
 
     async setFiatAmount(amount: string) {
         await this.getFiatAmountElement().replaceText(amount);
-        await wait(100);
+        const nonZeroRegex = /^(?!0+(?:\.0+)?$)\d+(\.\d+)?$/;
+        // await wait(999999);
+        await waitToHaveRegex(this.getReceiveCryptoAmountElement(), nonZeroRegex); // wait until the crypto amount is updated
         await this.getFiatAmountElement().tapReturnKey();
         await this.waitForQuotesToLoad();
     }
@@ -133,7 +141,7 @@ export abstract class TradingFormActions extends TradingActions {
             await networkFilterTab.tap();
         }
 
-        await waitForVisible(by.text(asset), { timeout: this.BOTTOM_SHEET_ANIMATION_DURATION });
+        await waitForVisible(by.text(asset));
         await element(by.text(asset)).tap();
 
         await waitFor(this.getElementById('asset-receive-button/symbol'))

suite-native/app/e2e/support/utils.ts

@@ -1,8 +1,16 @@
 import path from 'node:path';
 
-const isIndexableNativeElement = (
-    v: Detox.IndexableNativeElement | Detox.NativeMatcher,
-): v is Detox.IndexableNativeElement => {
+import { scheduleAction } from '@trezor/utils';
+
+type ElementAttributes = {
+    text?: string;
+    label?: string;
+    value?: string;
+};
+
+type ElementOrMatcher = Detox.IndexableNativeElement | Detox.NativeMatcher;
+
+const isIndexableNativeElement = (v: ElementOrMatcher): v is Detox.IndexableNativeElement => {
     const anyV = v as any;
 
     return !!anyV && (typeof anyV.tap === 'function' || typeof anyV.atIndex === 'function');
@@ -14,6 +22,11 @@ export const platform = device.getPlatform();
 // On the other hand, if we are trying to scroll to 100% visibility on iOS, it causes scrolling more than height of the screen and it makes Detox crash.
 const SCROLL_VISIBILITY_THRESHOLD = platform === 'android' ? 100 : undefined;
 
+export const RETRY_CONF = {
+    attempts: 5,
+    gap: 500,
+};
+
 export const wait = async (ms: number) => {
     await new Promise(resolve => setTimeout(resolve, ms));
 };
@@ -40,13 +53,17 @@ function pruneToAppStack(invocationStack: string): string {
     return kept.length ? ['Error'].concat(kept).join('\n') : invocationStack;
 }
 
+function getTarget(elementOrMatcher: ElementOrMatcher) {
+    return isIndexableNativeElement(elementOrMatcher)
+        ? elementOrMatcher
+        : element(elementOrMatcher);
+}
+
 export const waitForVisible = async (
-    elementOrMatcher: Detox.IndexableNativeElement | Detox.NativeMatcher,
+    elementOrMatcher: ElementOrMatcher,
     { timeout = 30_000 }: { timeout?: number } = {},
 ) => {
-    const target = isIndexableNativeElement(elementOrMatcher)
-        ? elementOrMatcher
-        : element(elementOrMatcher);
+    const target = getTarget(elementOrMatcher);
     const invocationStack = new Error().stack || '';
     try {
         await waitFor(target).toBeVisible().withTimeout(timeout);
@@ -58,6 +75,34 @@ export const waitForVisible = async (
     }
 };
 
+export const waitToHaveRegex = async (
+    elementOrMatcher: ElementOrMatcher,
+    expectedRegex: RegExp,
+    {
+        timeout = 30_000,
+        attributeType = 'text',
+    }: { timeout?: number; attributeType?: 'text' | 'label' | 'value' } = {},
+) => {
+    const target = getTarget(elementOrMatcher);
+    await waitForVisible(target, { timeout });
+    await scheduleAction(async () => {
+        const attributes = await target.getAttributes();
+        const testedAttribute = (attributes as ElementAttributes)[attributeType];
+
+        if (typeof testedAttribute !== 'string') {
+            throw new Error(
+                `waitForRegex(): could not get "${attributeType}" property from the element`,
+            );
+        }
+
+        if (!expectedRegex.test(testedAttribute)) {
+            throw new Error(
+                `waitForRegex(): target text "${testedAttribute}" not matching ${expectedRegex} after ${timeout}ms`,
+            );
+        }
+    }, RETRY_CONF);
+};
+
 export const appIsFullyLoaded = async () => {
     await waitForVisible(by.id('@screen/mainScrollView'), { timeout: 35_000 });
 };
@@ -85,9 +130,7 @@ export const inputTextToElement = async (element: Detox.IndexableNativeElement,
 };
 
 // Use this method in absolute necessity only! Try-catch in tests is discouraged because it may hide real issues.
-export const isElementVisible = async (
-    elementOrMatcher: Detox.IndexableNativeElement | Detox.NativeMatcher,
-): Promise<boolean> => {
+export const isElementVisible = async (elementOrMatcher: ElementOrMatcher): Promise<boolean> => {
     const target = isIndexableNativeElement(elementOrMatcher)
         ? elementOrMatcher
         : element(elementOrMatcher);
@@ -99,3 +142,20 @@ export const isElementVisible = async (
         return false;
     }
 };
+
+export function testWithRepeat(
+    runs: number,
+    name: string,
+    testFunction: () => Promise<void> | void,
+    timeout?: number,
+) {
+    for (let i = 1; i <= runs; i++) {
+        it(
+            name,
+            async () => {
+                await testFunction();
+            },
+            timeout,
+        );
+    }
+}

suite-native/app/e2e/tests/deviceSettingsT3T1.test.ts

@@ -22,7 +22,7 @@ conditionalDescribe(
         beforeEach(async () => {
             await openApp({ args: { preloadedState: preloadedStateT3T1 } });
             await prepareTrezorEmulator({ model: 'T3T1' });
-            await waitForVisible(by.id('@device-manager/connection-status'));
+            await onDeviceManager.assertDeviceSwitcherState({ title: 'Connected' });
             await onDeviceManager.tapDeviceSwitch();
             await onDeviceManager.tapDeviceSettingsButton();
         });

suite-native/app/e2e/tests/tradingBuyFlow.test.ts

@@ -11,8 +11,7 @@ const preloadedState = preparePreloadedReduxState(
     onboardingCompletedState,
 );
 
-// FIXME https://github.com/trezor/trezor-suite/issues/23518
-describe.skip('Trade Buy [@noDevice]', () => {
+describe('Trade Buy [@noDevice]', () => {
     beforeEach(async () => {
         await openApp({ args: { preloadedState } });
         await onHome.assertIsPortfolioGraphVisible();

suite-native/app/eslint.config.mjs

@@ -0,0 +1,9 @@
+import { eslint } from '@trezor/eslint';
+
+export default [
+    ...eslint,
+    {
+        files: ['**/e2e/support/**'],
+        rules: { 'jest/no-export': 'off' },
+    },
+];

suite-native/app/package.json

@@ -171,6 +171,7 @@
         "@suite-common/test-utils": "workspace:^",
         "@suite-native/test-utils": "workspace:*",
         "@trezor/connect-mobile": "workspace:^",
+        "@trezor/eslint": "workspace:^",
         "@types/node": "22.13.10",
         "@types/react-native-get-random-values": "1.8.2",
         "babel-jest": "29.7.0",

yarn.lock

@@ -11844,6 +11844,7 @@ __metadata:
     "@trezor/connect": "workspace:*"
     "@trezor/connect-mobile": "workspace:^"
     "@trezor/e2e-utils": "workspace:*"
+    "@trezor/eslint": "workspace:^"
     "@trezor/react-native-usb": "workspace:*"
     "@trezor/styles": "workspace:*"
     "@trezor/theme": "workspace:*"