Fix a few compile warnings

Author: treecase

src/gtk/classes/MapArea3D.cpp

@@ -96,12 +96,12 @@ Sickle::MapArea3D::MapArea3D(Editor::EditorRef ed)
 ,   Lua::Referenceable{}
 ,   _editor{ed}
 ,   _prop_camera{*this, "camera", DEFAULT_CAMERA}
+,   _prop_mouse_sensitivity{
+        *this, "mouse-sensitivity", DEFAULT_MOUSE_SENSITIVITY}
+,   _prop_shift_multiplier{*this, "grid-size", 2.0f}
 ,   _prop_state{*this, "state", {}}
 ,   _prop_transform{*this, "transform", DEFAULT_TRANSFORM}
 ,   _prop_wireframe{*this, "wireframe", false}
-,   _prop_shift_multiplier{*this, "grid-size", 2.0f}
-,   _prop_mouse_sensitivity{
-        *this, "mouse-sensitivity", DEFAULT_MOUSE_SENSITIVITY}
 {
     set_required_version(4, 3);
     set_use_es(false);

src/gtk/classes/appwin/propertyeditor/cellrenderers/CellRendererColor.cpp

@@ -41,9 +41,6 @@ void CellRendererColor::render_vfunc(
 {
     auto context = widget.get_style_context();
 
-    auto const xpad = property_xpad().get_value();
-    auto const ypad = property_ypad().get_value();
-
     auto const swatch_rect = _get_swatch_rect(cell_area);
 
 

src/gtk/classes/maparea2d/MapArea2D.cpp

@@ -62,8 +62,8 @@ Sickle::MapArea2D::MapArea2D(Editor::EditorRef ed)
 :   Glib::ObjectBase{typeid(MapArea2D)}
 ,   _editor{ed}
 ,   _css{Gtk::CssProvider::create()}
-,   _prop_grid_size{*this, "grid-size", 32}
 ,   _prop_draw_angle{*this, "draw-angle", DrawAngle::TOP}
+,   _prop_grid_size{*this, "grid-size", 32}
 ,   _prop_transform{*this, "transform", {}}
 ,   _brushbox_view{
         std::make_shared<BBox2ViewCustom>(

src/world3d/Face.cpp

@@ -141,7 +141,6 @@ void World3D::Face::_sync_vertices()
 
     auto const u_axis = glm::normalize(_src->get_u());
     auto const v_axis = glm::normalize(_src->get_v());
-    auto const normal = glm::normalize(glm::cross(u_axis, v_axis));
 
     auto const texture_size = (_texture
         ? glm::vec2{_texture->width, _texture->height}

src/world3d/Texture.cpp

@@ -94,7 +94,7 @@ std::shared_ptr<World3D::Texture> World3D::Texture::make_missing_texture()
         for (size_t x = 0; x < SIZE; ++x)
         {
             auto const idx = 4 * (y * SIZE + x);
-            if (x < HSIZE && y < HSIZE || x >= HSIZE && y >= HSIZE)
+            if ((x < HSIZE && y < HSIZE) || (x >= HSIZE && y >= HSIZE))
             {
                 pixels[idx+0] = 0x00;
                 pixels[idx+1] = 0x00;

src/world3d/raycast/BoxColliderBrush.cpp

@@ -33,7 +33,7 @@ void BoxColliderBrush::on_attach(Sickle::Componentable &obj)
     _src = &brush;
     _signals = std::make_unique<Signals>();
 
-    for (auto const face : _src->faces())
+    for (auto const &face : _src->faces())
     {
         _signals->conns.push_back(
             face->signal_vertices_changed().connect(
@@ -54,7 +54,7 @@ void BoxColliderBrush::on_detach(Sickle::Componentable &obj)
 void BoxColliderBrush::update_bbox()
 {
     BBox3 bbox{};
-    for (auto const face : _src->faces())
+    for (auto const &face : _src->faces())
         for (auto const vertex : face->get_vertices())
             bbox.add(vertex);
     set_box(bbox);