With warnings enabled, python complains about unclosed sqlite connection (`ResourceWarning`)

[hannob]

When running urlwatch with Pytthon warnings enabled, it will show a ResourceWarning with various commands (e.g., --edit, --test-filter) complaining that the database connection has not been closed.

Example commands:

PYTHONWARNINGS=d urlwatch --edit
PYTHONWARNINGS=d urlwatch --test-filter 1

Output at the end:

<sys>:0: ResourceWarning: unclosed database in <sqlite3.Connection object at 0x742d6ebf3880>
ResourceWarning: Enable tracemalloc to get the object allocation traceback

[thp]

A quick look at it, and it seems that for those action where we do an immediate sys.exit(), the self.urlwatcher.close() isn't run (which in turn calls self.cache_storage.close(), which in case of CacheMiniDBStorage does a self.db.close() on the minidb object that then closes the SQLite connection object).

Something like this could fix it:

diff --git a/lib/urlwatch/command.py b/lib/urlwatch/command.py
index cdafbbd..c859e65 100644
--- a/lib/urlwatch/command.py
+++ b/lib/urlwatch/command.py
@@ -485,11 +485,13 @@ class UrlwatchCommand:
             sys.exit(0)
 
     def run(self):
-        self.check_edit_config()
-        self.check_smtp_login()
-        self.check_telegram_chats()
-        self.check_xmpp_login()
-        self.check_test_reporter()
-        self.handle_actions()
-        self.urlwatcher.run_jobs()
-        self.urlwatcher.close()
+        try:
+            self.check_edit_config()
+            self.check_smtp_login()
+            self.check_telegram_chats()
+            self.check_xmpp_login()
+            self.check_test_reporter()
+            self.handle_actions()
+            self.urlwatcher.run_jobs()
+        finally:
+            self.urlwatcher.close()
diff --git a/lib/urlwatch/main.py b/lib/urlwatch/main.py
index 3c1c104..fe7cbc3 100644
--- a/lib/urlwatch/main.py
+++ b/lib/urlwatch/main.py
@@ -107,7 +107,7 @@ class Urlwatch(object):
 
     def run_jobs(self):
         run_jobs(self)
+        self.report.finish()
 
     def close(self):
-        self.report.finish()
         self.cache_storage.close()

Can you check if this fixes the problem for you? The real fix might be a bit more involved, I see e.g. prepare_jobs calling run_jobs() and close() on its own, but it should probably fall through. Needs a bit more thinking (does run_jobs() imply a self.report.finish()? but probably if we don't run jobs we don't want to call self.report.finish() and just close the cache storage, etc...

[hannob]

I can confirm that this patch fixes the --edit and --test-filter warnings.