Skip to content

Commit 3ca4b67

Browse files
committed
Upgrade to rules_python 1.7.0 (FAILS)
This demonstrates the regression in rules_python 1.7.0 where %interpreter_args% template placeholders are not substituted for external py_binary targets. Building the same target now fails: bazel build @com_github_grpc_grpc//src/python/grpcio/grpc/_cython:cygrpc.pyx_cython_translation Error: File ".../cython_binary", line 39 %interpreter_args% ^ SyntaxError: invalid syntax Root cause: PR #3242 introduced new template variables that native py_binary doesn't substitute. Fix: bazel-contrib/rules_python#3495
1 parent 1bb07d8 commit 3ca4b67

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

WORKSPACE

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ workspace(name = "rules_python_3495_repro")
22

33
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
44

5-
# rules_python 1.6.3 - works fine
5+
# rules_python 1.7.0 - has the regression (see PR #3495)
66
http_archive(
77
name = "rules_python",
8-
sha256 = "2f5c284fbb4e86045c2632d3573fc006facbca5d1fa02976e89dc0cd5488b590",
9-
strip_prefix = "rules_python-1.6.3",
10-
url = "https://github.com/bazel-contrib/rules_python/releases/download/1.6.3/rules_python-1.6.3.tar.gz",
8+
sha256 = "f609f341d6e9090b981b3f45324d05a819fd7a5a56434f849c761971ce2c47da",
9+
strip_prefix = "rules_python-1.7.0",
10+
url = "https://github.com/bazel-contrib/rules_python/releases/download/1.7.0/rules_python-1.7.0.tar.gz",
1111
)
1212

1313
load("@rules_python//python:repositories.bzl", "py_repositories", "python_register_toolchains")

0 commit comments

Comments
 (0)