improvement: Make the cpu_credits optional for workers launch template (#1030)

gillg · web-flow · commit 93614b329d1f · 2020-10-05T15:24:47.000+02:00
NOTES: `credit_specification` for worker groups launch template can now be set to `null` so that we can use non burstable EC2 families
diff --git a/workers_launch_template.tf b/workers_launch_template.tf
@@ -309,12 +309,15 @@ resource "aws_launch_template" "workers_launch_template" {
     )
   }
 
-  credit_specification {
-    cpu_credits = lookup(
+  dynamic "credit_specification" {
+    for_each = lookup(
       var.worker_groups_launch_template[count.index],
       "cpu_credits",
       local.workers_group_defaults["cpu_credits"]
-    )
+    ) != null ? [lookup(var.worker_groups_launch_template[count.index], "cpu_credits", local.workers_group_defaults["cpu_credits"])] : []
+    content {
+      cpu_credits = credit_specification.value
+    }
   }
 
   monitoring {

Original file line number	Diff line number	Diff line change
`@@ -309,12 +309,15 @@ resource "aws_launch_template" "workers_launch_template" {`
`309`	`309`	`)`
`310`	`310`	`}`
`311`	`311`
`312`		`- credit_specification {`
`313`		`- cpu_credits = lookup(`
	`312`	`+ dynamic "credit_specification" {`
	`313`	`+ for_each = lookup(`
`314`	`314`	`var.worker_groups_launch_template[count.index],`
`315`	`315`	`"cpu_credits",`
`316`	`316`	`local.workers_group_defaults["cpu_credits"]`
`317`		`- )`
	`317`	`+ ) != null ? [lookup(var.worker_groups_launch_template[count.index], "cpu_credits", local.workers_group_defaults["cpu_credits"])] : []`
	`318`	`+ content {`
	`319`	`+ cpu_credits = credit_specification.value`
	`320`	`+ }`
`318`	`321`	`}`
`319`	`322`
`320`	`323`	`monitoring {`