fix check for heartbeat timeout set

Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>

Author: tsurdilo

core/src/main/java/io/temporal/samples/autoheartbeat/activities/AutoActivities.java

@@ -26,4 +26,6 @@ public interface AutoActivities {
   String runActivityOne(String input);
 
   String runActivityTwo(String input);
+
+  String runActivityThree(String input);
 }

core/src/main/java/io/temporal/samples/autoheartbeat/activities/AutoActivitiesImpl.java

@@ -34,6 +34,11 @@ public String runActivityTwo(String input) {
     return runActivity("runActivityTwo - " + input, 10);
   }
 
+  @Override
+  public String runActivityThree(String input) {
+    return runActivity("runActivityThree - " + input, 3);
+  }
+
   @SuppressWarnings("FutureReturnValueIgnored")
   private String runActivity(String input, int seconds) {
     for (int i = 0; i < seconds; i++) {

core/src/main/java/io/temporal/samples/autoheartbeat/interceptor/AutoHeartbeatActivityInboundCallsInterceptor.java

@@ -47,7 +47,7 @@ public void init(ActivityExecutionContext context) {
   public ActivityOutput execute(ActivityInput input) {
     // If activity has heartbeat timeout defined we want to apply auto-heartbeter
     AutoHeartbeatUtil autoHearbeater = null;
-    if (activityHeartbeatTimeout != null) {
+    if (activityHeartbeatTimeout != null && activityHeartbeatTimeout.getSeconds() > 0) {
       System.out.println(
           "Auto heartbeating applied for activity: "
               + activityExecutionContext.getInfo().getActivityType());

core/src/main/java/io/temporal/samples/autoheartbeat/workflows/AutoWorkflowImpl.java

@@ -37,7 +37,9 @@ public class AutoWorkflowImpl implements AutoWorkflow {
   @Override
   public String exec(String input) {
     // Crete separate workflow stubs for same interface so we can show
-    // use of different heartbeat timeouts
+    // use of different heartbeat timeouts and activit that does not heartbeat
+    // Note you can do this also via WorkflowImplementationOptions instead of using different
+    // activity stubs if you wanted
     AutoActivities activitiesOne =
         Workflow.newActivityStub(
             AutoActivities.class,
@@ -54,13 +56,20 @@ public String exec(String input) {
                 .setHeartbeatTimeout(Duration.ofSeconds(3))
                 .build());
 
+    // Activity three does not heartbeat so autoheartbeat should not be applied to it
+    AutoActivities activitiesThree =
+        Workflow.newActivityStub(
+            AutoActivities.class,
+            ActivityOptions.newBuilder().setStartToCloseTimeout(Duration.ofSeconds(5)).build());
+
     // Start our activity in CancellationScope so we can cancel it if needed
     List<Promise<String>> activityPromises = new ArrayList<>();
     scope =
         Workflow.newCancellationScope(
             () -> {
               activityPromises.add(Async.function(activitiesOne::runActivityOne, input));
               activityPromises.add(Async.function(activitiesTwo::runActivityTwo, input));
+              activityPromises.add(Async.function(activitiesThree::runActivityThree, input));
             });
 
     scope.run();