Skip to content

Conversation

@rkirsling
Copy link
Member

@rkirsling rkirsling commented Apr 26, 2025

Currently, inline usage of <emu-grammar> has twice as much padding on the left as the right:
image
CSS-wise, we're using padding-left: 1ex; in this case, whereas the rest of the padding / margin involved in <emu-grammar> appears to use a value of 0.5ex instead.

I guess it's been this way for years, but it really looks like a visual bug, so I'm hereby proposing we make the left side 0.5ex as well, such that we get the following instead:
image

@michaelficarra
Copy link
Member

I actually kinda prefer the extra separation that 1ex gives us. Can you also provide a screenshot comparison of a balanced 1ex padding?

@rkirsling
Copy link
Member Author

rkirsling commented Apr 27, 2025

Adding padding-right: 0.5ex; to the status quo emu-production (such that that adds onto the 0.5ex right margin for elements within it) looks like this:
image

I do think that looks fine in the particular case above, but it seems less ideal when followed by a comma:
image

@bakkot bakkot merged commit 9b40686 into tc39:main May 15, 2025
2 checks passed
@rkirsling rkirsling deleted the fix-padding-of-inline-emu-grammar branch May 15, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants