Skip to content

Commit 91becd9

Browse files
fix(nsis): plugins not signed (#14627)
1 parent 018b4db commit 91becd9

File tree

2 files changed

+15
-7
lines changed

2 files changed

+15
-7
lines changed

.changes/nsis-plugin-sign-path.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
tauri-bundler: patch:bug
3+
---
4+
5+
Fix NSIS plugins not being signed due to wrong path handlings

crates/tauri-bundler/src/bundle/windows/nsis/mod.rs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -621,13 +621,16 @@ fn build_nsis_app_installer(
621621
fs::create_dir_all(nsis_installer_path.parent().unwrap())?;
622622

623623
if settings.windows().can_sign() {
624-
log::info!("Signing NSIS plugins");
625-
for dll in NSIS_PLUGIN_FILES {
626-
let path = additional_plugins_path.join(dll);
627-
if path.exists() {
628-
try_sign(&path, settings)?;
629-
} else {
630-
log::warn!("Could not find {}, skipping signing", path.display());
624+
if let Some(plugin_copy_path) = &maybe_plugin_copy_path {
625+
let plugin_copy_path = plugin_copy_path.join("x86-unicode");
626+
log::info!("Signing NSIS plugins");
627+
for dll in NSIS_PLUGIN_FILES {
628+
let path = plugin_copy_path.join(dll);
629+
if path.exists() {
630+
try_sign(&path, settings)?;
631+
} else {
632+
log::warn!("Could not find {}, skipping signing", path.display());
633+
}
631634
}
632635
}
633636
}

0 commit comments

Comments
 (0)