Commit 796d1e7
authored
chore: fix Vite ecosystem CI test (#15516)
This PR fixes our treeshaking tests so that it specifically looks for
`import { dev }`, etc. instead of just "dev". This helps avoid
false-positive test failures due to the component path being injected as
a comment in the build output that includes the export name we're trying
to assert isn't there
See
https://github.com/vitejs/vite-ecosystem-ci/actions/runs/22842250417/job/66257394232#step:7:3065
It also bumps the Vite 8 beta we use in CI to the latest one to catch
this issue. You can see from the test run that it now includes the
source file path in the build output as a comment
https://github.com/sveltejs/kit/actions/runs/22846427091/job/66263863728?pr=15517#step:10:584
---
### Please don't delete this checklist! Before submitting the PR, please
make sure you do the following:
- [ ] It's really useful if your PR references an issue where it is
discussed ahead of time. In many cases, features are absent for a
reason. For large changes, please create an RFC:
https://github.com/sveltejs/rfcs
- [ ] This message body should clearly illustrate what problems it
solves.
- [ ] Ideally, include a test that fails without this PR but passes with
it.
### Tests
- [ ] Run the tests with `pnpm test` and lint the project with `pnpm
lint` and `pnpm check`
### Changesets
- [ ] If your PR makes a change that should be noted in one or more
packages' changelogs, generate a changeset by running `pnpm changeset`
and following the prompts. Changesets that add features should be
`minor` and those that fix bugs should be `patch`. Please prefix
changeset messages with `feat:`, `fix:`, or `chore:`.
### Edits
- [ ] Please ensure that 'Allow edits from maintainers' is checked. PRs
without this option may be closed.1 parent d3387f9 commit 796d1e7
2 files changed
Lines changed: 3 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
888 | 888 | | |
889 | 889 | | |
890 | 890 | | |
891 | | - | |
892 | | - | |
| 891 | + | |
893 | 892 | | |
894 | 893 | | |
895 | 894 | | |
| |||
902 | 901 | | |
903 | 902 | | |
904 | 903 | | |
905 | | - | |
906 | | - | |
| 904 | + | |
907 | 905 | | |
908 | 906 | | |
909 | 907 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| |||
0 commit comments