update: really weird code

Author: supxinfy

.github/workflows/build.yml

@@ -129,35 +129,189 @@ jobs:
           mkdir dist
           Move-Item ${{ matrix.artifact }} dist\${{ matrix.artifact }}
 
-      - name: Package (Linux)
+      - name: Package (Linux) - AppImage
         if: matrix.os == 'ubuntu-latest'
         shell: bash
         run: |
-          mkdir -p krview/assets/fonts
-          mkdir -p krview/assets/screenshots
+          set -euo pipefail
+          APPDIR=AppDir
+          ARTIFACT_NAME=${{ matrix.artifact }}
 
-          cp zig-out/bin/krview krview/
-          cp assets/fonts/Terminus.ttf krview/assets/fonts/
-          cp assets/fonts/OFL.TXT krview/assets/fonts/
+          sudo apt-get update
+          sudo apt-get install -y patchelf wget
+
+          rm -rf "$APPDIR"
+          mkdir -p "$APPDIR"/usr/bin
+          mkdir -p "$APPDIR"/usr/lib
+          mkdir -p "$APPDIR"/usr/share/krview/assets/fonts
+          mkdir -p "$APPDIR"/usr/share/krview/assets/screenshots
+          mkdir -p "$APPDIR"/usr/share/applications
+          mkdir -p "$APPDIR"/usr/share/icons/hicolor/256x256/apps
+
+          # Copy binary + assets
+          cp zig-out/bin/krview "$APPDIR"/usr/bin/
+          chmod +x "$APPDIR"/usr/bin/krview
+          cp assets/fonts/Terminus.ttf "$APPDIR"/usr/share/krview/assets/fonts/
+          cp assets/fonts/OFL.TXT "$APPDIR"/usr/share/krview/assets/fonts/
+
+          # Collect shared libs used by the binary (exclude core glibc/ld and linux-vdso)
+          # Use sed to reliably extract the absolute path after the "=>"
+          ldd zig-out/bin/krview \
+            | sed -n 's/.*=> \(\/[^ ]*\).*/\1/p' \
+            | sort -u \
+            | grep -vE 'libc.so.6|ld-linux|linux-vdso' \
+            | while read -r lib; do
+                echo "Copying $lib"
+                cp -v "$lib" "$APPDIR"/usr/lib/ || true
+              done
+
+          # Optionally: also copy any symlink targets (sometimes ldd gives symlinks)
+          # and ensure they resolve correctly. The above cp usually copies the file the symlink points to.
+
+          # Ensure rpath is relative to AppImage's lib folder (patchelf accepts $ORIGIN literal)
+          patchelf --set-rpath '$ORIGIN/../lib' "$APPDIR"/usr/bin/krview
+
+          # AppRun that sets LD_LIBRARY_PATH and runs the binary
+          cat > "$APPDIR"/AppRun <<'EOF'
+#!/bin/sh
+HERE="$(dirname "$(readlink -f "${0}")")"
+export LD_LIBRARY_PATH="$HERE/usr/lib:${LD_LIBRARY_PATH-}"
+exec "$HERE/usr/bin/krview" "$@"
+EOF
+          chmod +x "$APPDIR"/AppRun
+
+          # Minimal desktop entry
+          cat > "$APPDIR"/usr/share/applications/krview.desktop <<'EOF'
+[Desktop Entry]
+Type=Application
+Name=krview
+Exec=krview
+Icon=krview
+Categories=Utility;
+EOF
+
+          # Copy icon (make sure assets/pictures/icon.png exists)
+          cp assets/pictures/icon.png "$APPDIR"/usr/share/icons/hicolor/256x256/apps/krview.png || true
+
+          # Download appimagetool (stable or continuous — choose what you prefer)
+          wget -q -O appimagetool-x86_64.AppImage \
+            https://github.com/AppImage/AppImageKit/releases/download/continuous/appimagetool-x86_64.AppImage
+          chmod +x appimagetool-x86_64.AppImage
 
-          tar -czf ${{ matrix.artifact }} krview
+          ./appimagetool-x86_64.AppImage "$APPDIR"
+
+          # Move produced AppImage into dist with predictable name
           mkdir -p dist
-          mv ${{ matrix.artifact }} dist/${{ matrix.artifact }}
+          mv -v *.AppImage "dist/${ARTIFACT_NAME}"
+
 
-      - name: Package (macOS)
+            - name: Package (macOS) - .app bundle
         if: matrix.os == 'macos-latest'
         shell: bash
         run: |
-          mkdir -p krview/assets/fonts
-          mkdir -p krview/assets/screenshots
+          set -euo pipefail
+          APP_NAME=krview
+          APP_BUNDLE="${APP_NAME}.app"
+          CONTENTS="$APP_BUNDLE/Contents"
+          MACOS_DIR="$CONTENTS/MacOS"
+          RESOURCES_DIR="$CONTENTS/Resources"
+          FRAMEWORKS_DIR="$CONTENTS/Frameworks"
+          ARTIFACT=${{ matrix.artifact }}
+
+          # Prepare bundle layout
+          rm -rf "$APP_BUNDLE"
+          mkdir -p "$MACOS_DIR" "$RESOURCES_DIR/assets/fonts" "$RESOURCES_DIR/assets/screenshots" "$FRAMEWORKS_DIR"
+
+          # Copy binary and assets
+          cp zig-out/bin/krview "$MACOS_DIR/$APP_NAME"
+          chmod +x "$MACOS_DIR/$APP_NAME"
+          cp -v assets/fonts/Terminus.ttf "$RESOURCES_DIR/assets/fonts/" || true
+          cp -v assets/fonts/OFL.TXT "$RESOURCES_DIR/assets/fonts/" || true
+          cp -v assets/pictures/icon.png "$RESOURCES_DIR/icon.png" || true
+
+          # Minimal Info.plist
+          cat > "$CONTENTS/Info.plist" <<'EOF'
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
+<plist version="1.0">
+<dict>
+  <key>CFBundleName</key><string>krview</string>
+  <key>CFBundleDisplayName</key><string>krview</string>
+  <key>CFBundleIdentifier</key><string>com.example.krview</string>
+  <key>CFBundleExecutable</key><string>krview</string>
+  <key>CFBundleVersion</key><string>1.0</string>
+  <key>CFBundlePackageType</key><string>APPL</string>
+  <key>LSMinimumSystemVersion</key><string>10.13</string>
+</dict>
+</plist>
+EOF
+
+          # Find non-system dylib/framework dependencies and copy them into Contents/Frameworks
+          # Exclude /usr/lib and /System libraries (these are system-provided).
+          otool -L zig-out/bin/krview | sed '1d' | awk '{print $1}' | sort -u | while read -r dep; do
+            # skip empty or system libs
+            if [ -z "$dep" ]; then continue; fi
+            case "$dep" in
+              /usr/lib/*|/System/*)
+                # system lib, skip
+                continue
+                ;;
+            esac
+
+            # If dependency is inside a .framework path, copy whole framework
+            if echo "$dep" | grep -qE '\.framework/'; then
+              # extract framework root (e.g. /opt/homebrew/Cellar/sdl2/2.0.16/Frameworks/SDL2.framework)
+              FROOT=$(echo "$dep" | sed -E 's@(.*/[^/]+\.framework)/.*@\1@')
+              FN=$(basename "$FROOT")
+              if [ ! -d "$FRAMEWORKS_DIR/$FN" ]; then
+                echo "Copying framework $FROOT -> $FRAMEWORKS_DIR/$FN"
+                cp -R "$FROOT" "$FRAMEWORKS_DIR/$FN"
+              fi
+              # change binary's reference to point to bundled framework
+              install_name_tool -change "$dep" "@executable_path/../Frameworks/$FN/$(basename "$dep")" "$MACOS_DIR/$APP_NAME" || true
+            else
+              # normal dylib: copy into Frameworks and rewrite binary reference
+              LIBNAME=$(basename "$dep")
+              if [ ! -f "$FRAMEWORKS_DIR/$LIBNAME" ]; then
+                echo "Copying dylib $dep -> $FRAMEWORKS_DIR/$LIBNAME"
+                cp -v "$dep" "$FRAMEWORKS_DIR/$LIBNAME" || true
+              fi
+              install_name_tool -change "$dep" "@executable_path/../Frameworks/$LIBNAME" "$MACOS_DIR/$APP_NAME" || true
+            fi
+          done
+
+          # Ensure binary will look into our Frameworks folder at runtime
+          install_name_tool -add_rpath "@executable_path/../Frameworks" "$MACOS_DIR/$APP_NAME" || true
+
+          # For copied dylibs: set their id to @rpath/<name> and fix internal references to each other
+          find "$FRAMEWORKS_DIR" -type f \( -name "*.dylib" -o -name "*.so" \) -print0 | while IFS= read -r -d '' LIB; do
+            BASENAME=$(basename "$LIB")
+            echo "Setting id for $LIB -> @rpath/$BASENAME"
+            install_name_tool -id "@rpath/$BASENAME" "$LIB" || true
+
+            # fix dependencies inside the dylib to point to @rpath if they are in our Frameworks folder
+            otool -L "$LIB" | sed '1d' | awk '{print $1}' | while read -r sub; do
+              case "$sub" in
+                /usr/lib/*|/System/*)
+                  continue
+                  ;;
+                *)
+                  SUBNAME=$(basename "$sub")
+                  if [ -f "$FRAMEWORKS_DIR/$SUBNAME" ]; then
+                    install_name_tool -change "$sub" "@rpath/$SUBNAME" "$LIB" || true
+                  fi
+                  ;;
+              esac
+            done
+          done
 
-          cp zig-out/bin/krview krview/
-          cp assets/fonts/Terminus.ttf krview/assets/fonts/
-          cp assets/fonts/OFL.TXT krview/assets/fonts/
+          # For copied frameworks: adjust binary references were handled above; some frameworks may contain inner dylibs
+          # (best-effort; for complex frameworks further corrections might be necessary)
 
-          tar -czf ${{ matrix.artifact }} krview
+          # Create the tarball artifact containing the .app bundle
           mkdir -p dist
-          mv ${{ matrix.artifact }} dist/${{ matrix.artifact }}
+          tar -czf "$ARTIFACT" "$APP_BUNDLE"
+          mv -v "$ARTIFACT" dist/"$ARTIFACT"
 
 
       - name: Upload artifact