chore: use RateCounterHelper.tick! to avoid waiting on tests (#1650)

Author: edgurgel

test/realtime/extensions/cdc_rls/subscriptions_test.exs

@@ -1,4 +1,4 @@
-defmodule Realtime.Extensions.PostgresCdcRls.Subscriptions do
+defmodule Realtime.Extensions.PostgresCdcRls.SubscriptionsTest do
   use RealtimeWeb.ChannelCase, async: true
 
   doctest Extensions.PostgresCdcRls.Subscriptions, import: true

test/realtime_web/channels/realtime_channel/broadcast_handler_test.exs

@@ -363,14 +363,13 @@ defmodule RealtimeWeb.RealtimeChannel.BroadcastHandlerTest do
         capture_log(fn ->
           {:noreply, _socket} = BroadcastHandler.handle(%{}, db_conn, socket)
 
-          # Enough for the RateCounter to calculate the last bucket
-          refute_receive _, 1200
+          {:ok, %{avg: avg}} = RateCounterHelper.tick!(Tenants.events_per_second_rate(tenant))
+          assert avg == 0.0
+
+          refute_receive _, 200
         end)
 
       assert log =~ "RlsPolicyError"
-
-      {:ok, %{avg: avg}} = RateCounterHelper.tick!(Tenants.events_per_second_rate(tenant))
-      assert avg == 0.0
     end
 
     test "handle payload size excedding limits in private channels", %{topic: topic, tenant: tenant, db_conn: db_conn} do

test/realtime_web/channels/realtime_channel/presence_handler_test.exs

@@ -438,7 +438,8 @@ defmodule RealtimeWeb.RealtimeChannel.PresenceHandlerTest do
       log =
         capture_log(fn ->
           for _ <- 1..300, do: PresenceHandler.handle(%{"event" => "track"}, db_conn, socket)
-          Process.sleep(1100)
+
+          {:ok, _} = RateCounterHelper.tick!(Tenants.presence_events_per_second_rate(tenant))
 
           assert {:error, :rate_limit_exceeded} = PresenceHandler.handle(%{"event" => "track"}, db_conn, socket)
         end)
@@ -453,7 +454,8 @@ defmodule RealtimeWeb.RealtimeChannel.PresenceHandlerTest do
       log =
         capture_log(fn ->
           for _ <- 1..300, do: PresenceHandler.handle(%{"event" => "track"}, db_conn, socket)
-          Process.sleep(1100)
+
+          {:ok, _} = RateCounterHelper.tick!(Tenants.presence_events_per_second_rate(tenant))
 
           assert {:error, :rate_limit_exceeded} = PresenceHandler.handle(%{"event" => "track"}, db_conn, socket)
         end)
@@ -521,7 +523,8 @@ defmodule RealtimeWeb.RealtimeChannel.PresenceHandlerTest do
       log =
         capture_log(fn ->
           for _ <- 1..300, do: PresenceHandler.handle(%{"event" => "track"}, db_conn, socket)
-          Process.sleep(1100)
+
+          {:ok, _} = RateCounterHelper.tick!(Tenants.presence_events_per_second_rate(tenant))
 
           assert {:error, :rate_limit_exceeded} = PresenceHandler.handle(%{"event" => "track"}, db_conn, socket)
         end)
@@ -537,7 +540,8 @@ defmodule RealtimeWeb.RealtimeChannel.PresenceHandlerTest do
       log =
         capture_log(fn ->
           for _ <- 1..300, do: PresenceHandler.handle(%{"event" => "track"}, db_conn, socket)
-          Process.sleep(1100)
+
+          {:ok, _} = RateCounterHelper.tick!(Tenants.presence_events_per_second_rate(tenant))
 
           assert {:error, :rate_limit_exceeded} = PresenceHandler.handle(%{"event" => "track"}, db_conn, socket)
         end)