Skip to content

Commit 0bd505b

Browse files
authored
Merge pull request #280 from storybookjs/pocka/upgrade-figspec
Upgrade figspec to v2
2 parents d02249b + 494ea72 commit 0bd505b

File tree

3 files changed

+50
-7
lines changed

3 files changed

+50
-7
lines changed

packages/storybook-addon-designs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"release": "npm run prepublishOnly && auto shipit"
4444
},
4545
"dependencies": {
46-
"@figspec/react": "^1.0.0"
46+
"@figspec/react": "^2.0.0"
4747
},
4848
"peerDependencies": {
4949
"@storybook/addon-docs": "^10.0.0 || ^10.0.0-0 || ^10.1.0-0 || ^10.2.0-0",

packages/storybook-addon-designs/src/manager/components/Figspec.tsx

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,15 @@ type RenderItem =
3232
type: "file";
3333
props: Pick<
3434
FigspecFileViewerProps,
35-
"documentNode" | "renderedImages" | "link"
35+
"apiResponse" | "renderedImages" | "link"
3636
>;
3737
}
3838
| {
3939
type: "frame";
40-
props: Pick<FigspecFrameViewerProps, "nodes" | "renderedImage" | "link">;
40+
props: Pick<
41+
FigspecFrameViewerProps,
42+
"apiResponse" | "renderedImage" | "link"
43+
>;
4144
};
4245

4346
type Remote<T, E = Error> =
@@ -139,7 +142,7 @@ export const Figspec: FC<Props> = ({ config }) => {
139142
value: {
140143
type: "file",
141144
props: {
142-
documentNode,
145+
apiResponse: documentNode,
143146
renderedImages: images.images,
144147
link: config.url,
145148
},
@@ -168,7 +171,11 @@ export const Figspec: FC<Props> = ({ config }) => {
168171
value: {
169172
type: "frame",
170173
props: {
171-
nodes,
174+
// Type mismatch due to different figma-js versions. As that library is
175+
// no longer maintained, upstream should mark this property `unknown` or
176+
// provided its own interface.
177+
apiResponse:
178+
nodes as unknown as FigspecFrameViewerProps["apiResponse"],
172179
renderedImage: Object.values<string>(images.images)[0],
173180
link: config.url,
174181
},

pnpm-lock.yaml

Lines changed: 38 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)