[FIX 1.9.24] Disable memo for all M addresses (#602)

* disable memo for all M addresses (classic + soroban transactions)

* handle disable memo for pre-cap67 contract addresses (e.g. MP collectibles)

* update tests for muxed address scenarios

* update tests for muxed address scenarios

Author: leofelix077

__tests__/components/TransactionSettingsBottomSheet.test.tsx

@@ -54,7 +54,7 @@ describe("muxedAddress helpers", () => {
   });
 
   describe("getMemoDisabledState", () => {
-    it("should disable memo for Soroban M addresses (M address with contractId)", async () => {
+    it("should disable memo for all M addresses (M address with contractId)", async () => {
       mockIsMuxedAccount.mockReturnValue(true);
 
       const result = await getMemoDisabledState({
@@ -70,16 +70,18 @@ describe("muxedAddress helpers", () => {
       );
     });
 
-    it("should allow memo for classic M addresses (M address without contractId)", async () => {
+    it("should disable memo for all M addresses (M address without contractId)", async () => {
       mockIsMuxedAccount.mockReturnValue(true);
 
       const result = await getMemoDisabledState({
         targetAddress: "M...",
         t: mockT,
       });
 
-      expect(result.isMemoDisabled).toBe(false);
-      expect(result.memoDisabledMessage).toBeUndefined();
+      expect(result.isMemoDisabled).toBe(true);
+      expect(result.memoDisabledMessage).toBe(
+        "translated:transactionSettings.memoInfo.memoDisabledForTransaction",
+      );
     });
 
     it("should allow memo for classic transactions (no contract)", async () => {
@@ -111,7 +113,7 @@ describe("muxedAddress helpers", () => {
       );
     });
 
-    it("should allow memo when contract does not support muxed but target is G address", async () => {
+    it("should disable memo when contract does not support muxed and target is G address", async () => {
       mockIsMuxedAccount.mockReturnValue(false);
       mockIsContractId.mockReturnValue(false);
       mockIsValidStellarAddress.mockReturnValue(true);
@@ -124,8 +126,10 @@ describe("muxedAddress helpers", () => {
         t: mockT,
       });
 
-      expect(result.isMemoDisabled).toBe(false);
-      expect(result.memoDisabledMessage).toBeUndefined();
+      expect(result.isMemoDisabled).toBe(true);
+      expect(result.memoDisabledMessage).toBe(
+        "translated:transactionSettings.memoInfo.memoNotSupportedForOperation",
+      );
     });
 
     it("should disable memo when contract does not support muxed and target is M address", async () => {
@@ -181,7 +185,7 @@ describe("muxedAddress helpers", () => {
       );
     });
 
-    it("should allow memo on error checking contract when target is G address", async () => {
+    it("should disable memo on error checking contract when target is G address", async () => {
       mockIsMuxedAccount.mockReturnValue(false);
       mockIsContractId.mockReturnValue(false);
       mockIsValidStellarAddress.mockReturnValue(true);
@@ -196,8 +200,10 @@ describe("muxedAddress helpers", () => {
         t: mockT,
       });
 
-      expect(result.isMemoDisabled).toBe(false);
-      expect(result.memoDisabledMessage).toBeUndefined();
+      expect(result.isMemoDisabled).toBe(true);
+      expect(result.memoDisabledMessage).toBe(
+        "translated:transactionSettings.memoInfo.memoNotSupportedForOperation",
+      );
     });
 
     it("should disable memo on error checking contract when target is M address", async () => {

__tests__/helpers/muxedAddress.test.ts

@@ -22,7 +22,6 @@ import {
   formatFiatAmount,
   stroopToXlm,
 } from "helpers/formatAmount";
-import { isSorobanTransaction as checkIsSorobanTransaction } from "helpers/soroban";
 import { truncateAddress, isMuxedAccount } from "helpers/stellar";
 import { getStellarExpertUrl } from "helpers/stellarExpert";
 import useAppTranslation from "hooks/useAppTranslation";
@@ -111,18 +110,10 @@ const TransactionDetailsBottomSheet: React.FC<
     recipientAddress && isMuxedAccount(recipientAddress),
   );
 
-  // Check if this is a Soroban transaction (custom token or contract address)
-  const isSorobanTransaction = checkIsSorobanTransaction(
-    selectedBalance,
-    recipientAddress,
-  );
-
-  // Only hide memo for Soroban M addresses (M addresses in Soroban transactions)
-  // Normal transactions support M address + memo
-  // Custom tokens to G addresses support memo
+  // Hide memo for M addresses (memo is encoded in the address)
   let memo = "";
-  // Always extract memo from transaction or use stored memo, unless it's a Soroban M address
-  if (!(isRecipientMuxed && isSorobanTransaction)) {
+  // Only extract memo from transaction or use stored memo if recipient is not an M address
+  if (!isRecipientMuxed) {
     if ("memo" in transaction && transaction.memo.value) {
       memo = String(transaction.memo.value);
     } else if (transactionMemo) {
@@ -319,9 +310,8 @@ const TransactionDetailsBottomSheet: React.FC<
                 </Text>
               ),
             },
-            // Hide memo line only for Soroban M addresses (M addresses in Soroban transactions)
-            // Normal transactions support M address + memo
-            !(isRecipientMuxed && isSorobanTransaction)
+            // Hide memo line for M addresses (memo is encoded in the address)
+            !isRecipientMuxed
               ? {
                   icon: (
                     <Icon.File02

src/components/TransactionDetailsBottomSheet.tsx

@@ -85,14 +85,6 @@ export const TransactionDetailsBottomSheetCustomContent: React.FC<
     ? isMuxedAccount(destinationAddress)
     : false;
 
-  // Check if this is a Soroban transaction (custom token or collectible transfer)
-  // Soroban transactions to M addresses don't support separate memo (memo is encoded in address)
-  // Soroban transactions to G addresses support memo
-  // Normal transactions (payments) support M address + memo
-  const isSorobanTransaction =
-    transactionDetails.transactionType === TransactionType.CONTRACT_TRANSFER ||
-    transactionDetails.transactionType === TransactionType.CONTRACT;
-
   const detailItems = useMemo(
     () =>
       [
@@ -119,10 +111,8 @@ export const TransactionDetailsBottomSheetCustomContent: React.FC<
             </Text>
           ),
         },
-        // Hide memo line only for Soroban transactions (custom tokens or collectibles) to M addresses
-        // Soroban transactions to G addresses support memo
-        // Normal transactions support M address + memo
-        !(isDestinationMuxed && isSorobanTransaction)
+        // Hide memo line for M addresses (memo is encoded in the address)
+        !isDestinationMuxed
           ? {
               icon: (
                 <Icon.File02 size={16} color={themeColors.foreground.primary} />
@@ -199,7 +189,6 @@ export const TransactionDetailsBottomSheetCustomContent: React.FC<
       transactionDetails.memo,
       transactionDetails.xdr,
       isDestinationMuxed,
-      isSorobanTransaction,
     ],
   ) as ListItemProps[];
 

src/components/screens/HistoryScreen/TransactionDetailsBottomSheetCustomContent.tsx

@@ -19,7 +19,6 @@ import { useTransactionSettingsStore } from "ducks/transactionSettings";
 import { isLiquidityPool } from "helpers/balances";
 import { pxValue } from "helpers/dimensions";
 import { formatTokenForDisplay, formatFiatAmount } from "helpers/formatAmount";
-import { isSorobanTransaction as checkIsSorobanTransaction } from "helpers/soroban";
 import { truncateAddress, isMuxedAccount } from "helpers/stellar";
 import useAppTranslation from "hooks/useAppTranslation";
 import { useClipboard } from "hooks/useClipboard";
@@ -195,12 +194,6 @@ const SendReviewBottomSheet: React.FC<SendReviewBottomSheetProps> = ({
 
   const isRecipientMuxed = isMuxedAccount(recipientAddress);
 
-  // Check if this is a Soroban transaction (custom token or contract address)
-  const isSorobanTransaction = checkIsSorobanTransaction(
-    selectedBalance,
-    recipientAddress,
-  );
-
   const transactionDetailsList: ListItemProps[] = useMemo(
     () =>
       [
@@ -223,9 +216,8 @@ const SendReviewBottomSheet: React.FC<SendReviewBottomSheetProps> = ({
             </View>
           ),
         },
-        // Hide memo line only for Soroban M addresses (M addresses in Soroban transactions)
-        // Normal transactions support M address + memo
-        !(isRecipientMuxed && isSorobanTransaction)
+        // Hide memo line for M addresses (memo is encoded in the address)
+        !isRecipientMuxed
           ? {
               icon: (
                 <Icon.File02 size={16} color={themeColors.foreground.primary} />
@@ -282,7 +274,6 @@ const SendReviewBottomSheet: React.FC<SendReviewBottomSheetProps> = ({
       transactionMemo,
       transactionXDR,
       isRecipientMuxed,
-      isSorobanTransaction,
     ],
   );
 

src/components/screens/SendScreen/components/SendReviewBottomSheet.tsx

@@ -284,13 +284,12 @@ const TransactionAmountScreen: React.FC<TransactionAmountScreenProps> = ({
     recipientAddress && isMuxedAccount(recipientAddress),
   );
 
-  // Clear memo only for Soroban M addresses (custom tokens / contract addresses)
-  // Normal transactions support M address + memo
+  // Clear memo for all M addresses (memo is encoded in the address)
   useEffect(() => {
-    if (isRecipientMuxed && isCustomToken && transactionMemo) {
+    if (isRecipientMuxed && transactionMemo) {
       saveMemo("");
     }
-  }, [isRecipientMuxed, isCustomToken, transactionMemo, saveMemo]);
+  }, [isRecipientMuxed, transactionMemo, saveMemo]);
 
   const contractId = useMemo(() => {
     if (

src/components/screens/SendScreen/screens/TransactionAmountScreen.tsx

@@ -29,10 +29,8 @@ export async function getMemoDisabledState(
 ): Promise<MemoDisabledState> {
   const { targetAddress, contractId, networkDetails, t } = params;
 
-  // Only disable memo for Soroban M addresses (when there's a contractId AND target is M address)
-  // Normal transactions support M address + memo
-  // Custom tokens to G addresses support memo
-  if (isMuxedAccount(targetAddress) && contractId) {
+  // Disable memo for all M addresses (memo is encoded in the address)
+  if (isMuxedAccount(targetAddress)) {
     return {
       isMemoDisabled: true,
       memoDisabledMessage: t(
@@ -63,17 +61,15 @@ export async function getMemoDisabledState(
     };
   }
 
-  // For Soroban transactions (custom tokens), memo is supported for G addresses
-  // Only disable memo if contract doesn't support muxed AND target is M address
+  // For Soroban transactions (custom tokens/collectibles) with G addresses:
+  // Memo is only supported if the contract supports muxed (has to_muxed property)
   try {
     const contractSupportsMuxed = await checkContractSupportsMuxed({
       contractId,
       networkDetails,
     });
 
-    // If contract doesn't support muxed and target is M address, disable memo
-    // (because we'll need to convert M to G, and memo can't be encoded)
-    if (!contractSupportsMuxed && isMuxedAccount(targetAddress)) {
+    if (!contractSupportsMuxed) {
       return {
         isMemoDisabled: true,
         memoDisabledMessage: t(
@@ -82,15 +78,15 @@ export async function getMemoDisabledState(
       };
     }
 
-    // For G addresses in Soroban transactions, memo is always supported
-    // For M addresses in Soroban transactions with muxed support, memo is disabled (encoded in address)
     return { isMemoDisabled: false, memoDisabledMessage: undefined };
   } catch (error) {
-    // On error, only disable memo if target is M address (to be safe)
-    if (isMuxedAccount(targetAddress)) {
-      return { isMemoDisabled: true, memoDisabledMessage: undefined };
-    }
-    return { isMemoDisabled: false, memoDisabledMessage: undefined };
+    // On error, disable memo for safety (assume contract doesn't support muxed)
+    return {
+      isMemoDisabled: true,
+      memoDisabledMessage: t(
+        "transactionSettings.memoInfo.memoNotSupportedForOperation",
+      ),
+    };
   }
 }
 

src/helpers/muxedAddress.ts

@@ -31,6 +31,7 @@ import {
   isValidStellarAddress,
   isSameAccount,
   getBaseAccount,
+  isMuxedAccount,
 } from "helpers/stellar";
 import { t } from "i18next";
 import { analytics } from "services/analytics";
@@ -375,9 +376,11 @@ export const buildPaymentTransaction = async (
 
     const isToContractAddress = isContractId(recipientAddress);
     const shouldUseSorobanTransfer = isToContractAddress || isCustomToken;
-    // For normal transactions (non-Soroban), allow memo even with M addresses
+    const isRecipientMuxed = isMuxedAccount(recipientAddress);
+    // Don't add memo for M addresses (memo is encoded in the address)
+    // For normal transactions (non-Soroban), only add memo if recipient is not M address
     // For Soroban transactions, memo handling is done in buildSorobanTransferOperation
-    if (memo && !shouldUseSorobanTransfer) {
+    if (memo && !shouldUseSorobanTransfer && !isRecipientMuxed) {
       transactionBuilder.addMemo(new Memo(Memo.text(memo).type, memo));
     }