Skip to content

Commit ea30d86

Browse files
committed
refactor: exclude manifest.json deps from dependency resolution
This avoids scenarios where the JavaScript dependency tree is free of cycles, as is the C dependency tree, but intermingling the two trees causes spurious cycles. Excluding `manifest.json` deps from topological sorting does introduce risk; however, any manifest.json dep cycles should be caught during build time during compilation and never hit production, as they should be caught earlier in the process and by other means. --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent bb36da3 commit ea30d86

File tree

1 file changed

+2
-1
lines changed
  • lib/node_modules/@stdlib/_tools/pkgs/toposort/lib

1 file changed

+2
-1
lines changed

lib/node_modules/@stdlib/_tools/pkgs/toposort/lib/sort.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ var format = require( '@stdlib/string/format' );
3333

3434
var debug = logger( 'pkgs:toposort:sort' );
3535
var OPTS = {
36-
'dev': false
36+
'dev': false,
37+
'manifest': false
3738
};
3839

3940

0 commit comments

Comments
 (0)