Skip to content

Commit ee49c01

Browse files
committed
update opencl test to use bounded uniform rng instead of (INT_MIN, INT_MAX)
1 parent 545caef commit ee49c01

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

test/unit/math/opencl/rev/binomial_logit_glm_lpmf_test.cpp

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
#include <stan/math/opencl/rev.hpp>
44
#include <gtest/gtest.h>
55
#include <test/unit/math/opencl/util.hpp>
6+
#include <random>
67
#include <vector>
78

89
TEST(ProbDistributionsBinomialLogitGLM, error_checking) {
@@ -203,9 +204,12 @@ TEST(ProbDistributionsBinomialLogitGLM, opencl_matches_cpu_big) {
203204

204205
std::vector<int> n(N);
205206
std::vector<int> trials(N);
207+
std::mt19937 rng(12345);
208+
std::uniform_int_distribution<int> n_dist(0, 50);
209+
std::uniform_int_distribution<int> extra_dist(0, 50);
206210
for (int i = 0; i < N; i++) {
207-
n[i] = Eigen::ArrayXi::Random(1, 1).abs()(0);
208-
trials[i] = n[i] + Eigen::ArrayXi::Random(1, 1).abs()(0);
211+
n[i] = n_dist(rng);
212+
trials[i] = n[i] + extra_dist(rng);
209213
}
210214
Eigen::MatrixXd x = Eigen::MatrixXd::Random(N, M);
211215
Eigen::VectorXd beta = Eigen::VectorXd::Random(M);

0 commit comments

Comments
 (0)