Skip to content

[Feature request] Expose DefaultModulithObservationConvention #1444

@alturkovic

Description

@alturkovic

I would like to add two more high-cardinality tags: bean name and class name of the invoked methods. I can see that Modulith has a package-private implementation: DefaultModulithObservationConvention which seems like something I want to extend.

This would make tracing a little bit easier at cost of these 2 new tags.

The default implementation has EventListener specific tag logic I would like to keep. If I define my own ModulithObservationConvention, I would have to copy/paste the default behavior in order to add my 2 new tags.

Would it be possible to make DefaultModulithObservationConvention public so users can extend it and add tags on top of the default behavior instead of replacing it or is there already a better way to add new tags on top of the existing ones?

StackOverflow thread: https://stackoverflow.com/questions/79800345/expanding-spring-modulith-tracing-tags/

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions