Increase e2e test coverage

Signed-off-by: Juan Cruz Viotti <[email protected]>

Author: jviotti

test/vscode/extension.test.ts

@@ -0,0 +1 @@
+{broken json

test/vscode/fixtures/invalid-json.json

@@ -0,0 +1,17 @@
+{
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "title": "Schema with non-root lint issues",
+  "description": "Triggers enum_with_type and enum_to_const at non-root positions",
+  "examples": [
+    {
+      "status": "active"
+    }
+  ],
+  "type": "object",
+  "properties": {
+    "status": {
+      "type": "string",
+      "enum": [ "active" ]
+    }
+  }
+}

test/vscode/fixtures/non-root-lint-schema.json

@@ -0,0 +1,7 @@
+{
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "type": "object",
+  "title": "Unformatted schema",
+  "description": "Keywords in wrong order for the formatter",
+  "examples": [ {} ]
+}

test/vscode/fixtures/unformatted-schema.json

@@ -0,0 +1,18 @@
+{
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
+  "title": "A valid test schema",
+  "description": "This schema passes lint, metaschema, and format checks",
+  "examples": [
+    {
+      "name": "test"
+    }
+  ],
+  "type": "object",
+  "properties": {
+    "name": {
+      "title": "Name",
+      "description": "The name field",
+      "type": "string"
+    }
+  }
+}

test/vscode/fixtures/valid-schema.json

@@ -6,9 +6,7 @@
   "scripts": {
     "compile": "tsc -p ./",
     "pretest": "npm run compile",
-    "test": "vscode-test",
-    "test:headed": "vscode-test --headless=false",
-    "test:watch": "vscode-test --watch"
+    "test": "vscode-test"
   },
   "devDependencies": {
     "@types/chai": "^5.2.3",

test/vscode/package.json

@@ -117,7 +117,7 @@ export class DiagnosticManager {
 
                 diagnostic.source = 'Sourcemeta Studio (Metaschema)';
 
-                if (error.instanceLocation) {
+                if (error.instanceLocation !== undefined) {
                     diagnostic.code = error.instanceLocation;
                 }
 

vscode/src/diagnostics/DiagnosticManager.ts

@@ -54,6 +54,10 @@ export async function activate(context: vscode.ExtensionContext): Promise<void>
         handleWebviewMessage(message);
     });
 
+    panelManager.setDisposeHandler(() => {
+        diagnosticManager.clearAll();
+    });
+
     const openPanelCommand = vscode.commands.registerCommand('sourcemeta-studio.openPanel', () => {
         webviewReady = false;
         panelManager.createOrReveal(context);

vscode/src/extension.ts

@@ -11,6 +11,7 @@ export class PanelManager {
     private readonly iconPath: vscode.Uri;
     private readonly extensionPath: string;
     private messageHandler?: (message: WebviewToExtensionMessage) => void;
+    private disposeHandler?: () => void;
 
     constructor(extensionPath: string) {
         this.extensionPath = extensionPath;
@@ -24,6 +25,10 @@ export class PanelManager {
         this.messageHandler = handler;
     }
 
+    setDisposeHandler(handler: () => void): void {
+        this.disposeHandler = handler;
+    }
+
     /**
      * Create or reveal the panel
      */
@@ -70,10 +75,12 @@ export class PanelManager {
             context.subscriptions
         );
 
-        // Handle panel disposal
         this.panel.onDidDispose(
             () => {
                 this.panel = undefined;
+                if (this.disposeHandler) {
+                    this.disposeHandler();
+                }
             },
             null,
             context.subscriptions